[Clang][NFC] Move HeadingAndSpellings to avoid copying (#143611)

shafik · web-flow · commit f39f53e569f9 · 2025-06-11T14:11:19.000-07:00
Static analysis flagged that we could move HeadingAndSpellings and avoid
a copy of a large object.
diff --git a/clang/utils/TableGen/ClangAttrEmitter.cpp b/clang/utils/TableGen/ClangAttrEmitter.cpp
@@ -5405,7 +5405,7 @@ void EmitClangAttrDocs(const RecordKeeper &Records, raw_ostream &OS) {
       // Handle Undocumented category separately - no content merging
       if (Cat == "Undocumented" && UndocumentedCategory) {
         UndocumentedDocs.push_back(
-            DocumentationData(Doc, Attr, HeadingAndSpellings));
+            DocumentationData(Doc, Attr, std::move(HeadingAndSpellings)));
         continue;
       }
 

Original file line number	Diff line number	Diff line change
`@@ -5405,7 +5405,7 @@ void EmitClangAttrDocs(const RecordKeeper &Records, raw_ostream &OS) {`
`5405`	`5405`	`// Handle Undocumented category separately - no content merging`
`5406`	`5406`	`if (Cat == "Undocumented" && UndocumentedCategory) {`
`5407`	`5407`	`UndocumentedDocs.push_back(`
`5408`		`- DocumentationData(Doc, Attr, HeadingAndSpellings));`
	`5408`	`+ DocumentationData(Doc, Attr, std::move(HeadingAndSpellings)));`
`5409`	`5409`	`continue;`
`5410`	`5410`	`}`
`5411`	`5411`