Skip to content

Commit f3a12ba

Browse files
committed
Add missing eReturnStatusSuccessFinishNoResult
1 parent 5ede432 commit f3a12ba

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

lldb/source/Interpreter/CommandObject.cpp

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -120,20 +120,24 @@ bool CommandObject::ParseOptions(Args &args, CommandReturnObject &result) {
120120
if (args_or) {
121121
args = std::move(*args_or);
122122
error = options->NotifyOptionParsingFinished(&exe_ctx);
123-
} else
123+
} else {
124124
error = Status::FromError(args_or.takeError());
125+
}
125126

126-
if (error.Success()) {
127-
if (llvm::Error error = options->VerifyOptions()) {
128-
result.SetError(std::move(error));
129-
return false;
130-
}
131-
return true;
127+
if (error.Fail()) {
128+
result.SetError(error.takeError());
129+
result.SetStatus(eReturnStatusFailed);
130+
return false;
132131
}
133132

134-
result.SetError(error.takeError());
135-
result.SetStatus(eReturnStatusFailed);
136-
return false;
133+
if (llvm::Error error = options->VerifyOptions()) {
134+
result.SetError(std::move(error));
135+
result.SetStatus(eReturnStatusFailed);
136+
return false;
137+
}
138+
139+
result.SetStatus(eReturnStatusSuccessFinishNoResult);
140+
return true;
137141
}
138142
return true;
139143
}

0 commit comments

Comments
 (0)