Address nits comments

Author: clementval

mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td

@@ -1236,7 +1236,7 @@ def NVVM_FenceProxyAcquireOp : NVVM_Op<"fence.proxy.acquire">,
   let hasVerifier = 1;
 }
 
-def NVVM_MembarOp : NVVM_Op<"memory_barrier">,
+def NVVM_MembarOp : NVVM_Op<"memory.barrier">,
                     Arguments<(ins MemScopeKindAttr:$scope)> {
   let summary = "Memory barrier operation";
   let description = [{

mlir/lib/Target/LLVMIR/Dialect/NVVM/NVVMToLLVMIRTranslation.cpp

@@ -293,20 +293,16 @@ static unsigned getUnidirectionalFenceProxyID(NVVM::ProxyKind fromProxy,
 
 static unsigned getMembarIntrinsicID(NVVM::MemScopeKind scope) {
   switch (scope) {
-  case NVVM::MemScopeKind::CTA: {
+  case NVVM::MemScopeKind::CTA:
     return llvm::Intrinsic::nvvm_membar_cta;
-  }
-  case NVVM::MemScopeKind::CLUSTER: {
+  case NVVM::MemScopeKind::CLUSTER:
     return llvm::Intrinsic::nvvm_fence_sc_cluster;
-  }
-  case NVVM::MemScopeKind::GPU: {
+  case NVVM::MemScopeKind::GPU:
     return llvm::Intrinsic::nvvm_membar_gl;
-  }
-  case NVVM::MemScopeKind::SYS: {
+  case NVVM::MemScopeKind::SYS:
     return llvm::Intrinsic::nvvm_membar_sys;
   }
-  }
-  llvm_unreachable("Unknown level for memory barrier");
+  llvm_unreachable("Unknown scope for memory barrier");
 }
 
 #define TCGEN05LD(SHAPE, NUM) llvm::Intrinsic::nvvm_tcgen05_ld_##SHAPE##_##NUM

mlir/test/Target/LLVMIR/nvvm/membar.mlir

@@ -3,12 +3,12 @@
 // CHECK-lABEL: @memorybarrier()
 llvm.func @memorybarrier() {
   // CHECK: call void @llvm.nvvm.membar.cta()
-  nvvm.memory_barrier #nvvm.mem_scope<cta>
+  nvvm.memory.barrier #nvvm.mem_scope<cta>
   // CHECK: call void @llvm.nvvm.fence.sc.cluster()
-  nvvm.memory_barrier #nvvm.mem_scope<cluster>
+  nvvm.memory.barrier #nvvm.mem_scope<cluster>
   // CHECK: call void @llvm.nvvm.membar.gl()
-  nvvm.memory_barrier #nvvm.mem_scope<gpu>
+  nvvm.memory.barrier #nvvm.mem_scope<gpu>
   // CHECK: call void @llvm.nvvm.membar.sys()
-  nvvm.memory_barrier #nvvm.mem_scope<sys>
+  nvvm.memory.barrier #nvvm.mem_scope<sys>
   llvm.return
 }