Skip to content

Commit f3da569

Browse files
committed
Use FlatSymbolRefAttr instead of StringAttr
1 parent e9e87d4 commit f3da569

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1220,8 +1220,8 @@ def LLVM_PoisonAttr : LLVM_Attr<"Poison", "poison">;
12201220
/// Folded into from LLVM::DSOLocalEquivalentOp.
12211221
def LLVM_DSOLocalEquivalentAttr : LLVM_Attr<"DSOLocalEquivalent",
12221222
"dso_local_equivalent"> {
1223-
let parameters = (ins "StringAttr":$name);
1224-
let assemblyFormat = "$name";
1223+
let parameters = (ins "FlatSymbolRefAttr":$sym);
1224+
let assemblyFormat = "$sym";
12251225
}
12261226

12271227
//===----------------------------------------------------------------------===//

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2170,8 +2170,7 @@ DSOLocalEquivalentOp::verifySymbolUses(SymbolTableCollection &symbolTable) {
21702170
/// Fold a dso_local_equivalent operation to a dedicated dso_local_equivalent
21712171
/// attribute.
21722172
OpFoldResult DSOLocalEquivalentOp::fold(FoldAdaptor) {
2173-
return DSOLocalEquivalentAttr::get(getContext(),
2174-
getFunctionNameAttr().getAttr());
2173+
return DSOLocalEquivalentAttr::get(getContext(), getFunctionNameAttr());
21752174
}
21762175

21772176
//===----------------------------------------------------------------------===//

mlir/lib/Target/LLVMIR/ModuleImport.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1253,7 +1253,10 @@ FailureOr<Value> ModuleImport::convertConstant(llvm::Constant *constant) {
12531253
Type type = convertType(dsoLocalEquivalent->getType());
12541254
return builder
12551255
.create<DSOLocalEquivalentOp>(
1256-
loc, type, dsoLocalEquivalent->getGlobalValue()->getName())
1256+
loc, type,
1257+
FlatSymbolRefAttr::get(
1258+
builder.getContext(),
1259+
dsoLocalEquivalent->getGlobalValue()->getName()))
12571260
.getResult();
12581261
}
12591262

0 commit comments

Comments
 (0)