Add new test cases.

Author: weiguozhi

llvm/lib/Transforms/InstCombine/InstructionCombining.cpp

@@ -1692,7 +1692,7 @@ Instruction *InstCombinerImpl::FoldOpIntoSelect(Instruction &Op, SelectInst *SI,
 
   Value *TV = SI->getTrueValue();
   Value *FV = SI->getFalseValue();
-  if ((Op.getOpcode() == Instruction::ExtractValue) &&
+  if (Op.getOpcode() == Instruction::ExtractValue &&
       (isa<InsertValueInst>(TV) || isa<InsertValueInst>(FV))) {
     // extract (select (cond, insert(agg, elem), FV))
     // -> select (cond, elem, extract(FV))

llvm/test/Transforms/InstCombine/extract-select-agg.ll

@@ -77,8 +77,8 @@ entry:
 
 declare void @use(i64)
 
-define i64 @test_extract_select_insert(ptr %p1, i64 %v) {
-; CHECK-LABEL: define i64 @test_extract_select_insert(
+define i64 @test_extract_select_insert_left(ptr %p1, i64 %v) {
+; CHECK-LABEL: define i64 @test_extract_select_insert_left(
 ; CHECK-SAME: ptr [[P1:%.*]], i64 [[V:%.*]]) {
 ; CHECK-NEXT:    [[CALL:%.*]] = call { ptr, i64 } @foo()
 ; CHECK-NEXT:    [[ELM1:%.*]] = extractvalue { ptr, i64 } [[CALL]], 1
@@ -97,4 +97,46 @@ define i64 @test_extract_select_insert(ptr %p1, i64 %v) {
   ret i64 %res
 }
 
+define i64 @test_extract_select_insert_right(ptr %p1, i64 %v) {
+; CHECK-LABEL: define i64 @test_extract_select_insert_right(
+; CHECK-SAME: ptr [[P1:%.*]], i64 [[V:%.*]]) {
+; CHECK-NEXT:    [[CALL:%.*]] = call { ptr, i64 } @foo()
+; CHECK-NEXT:    [[ELM1:%.*]] = extractvalue { ptr, i64 } [[CALL]], 1
+; CHECK-NEXT:    [[CMP:%.*]] = icmp eq i64 [[ELM1]], [[V]]
+; CHECK-NEXT:    [[TMP1:%.*]] = extractvalue { ptr, i64 } [[CALL]], 1
+; CHECK-NEXT:    [[RES:%.*]] = select i1 [[CMP]], i64 [[TMP1]], i64 4294967294
+; CHECK-NEXT:    ret i64 [[RES]]
+;
+  %call = call { ptr, i64 } @foo()
+  %elm1 = extractvalue { ptr, i64 } %call, 1
+  %cmp = icmp eq i64 %elm1, %v
+  %fca0 = insertvalue { ptr, i64 } poison, ptr %p1, 0
+  %fca1 = insertvalue { ptr, i64 } %fca0, i64 4294967294, 1
+  %select = select i1 %cmp, { ptr, i64 } %call, { ptr, i64 } %fca1
+  %res = extractvalue { ptr, i64 } %select, 1
+  ret i64 %res
+}
+
+define i64 @test_extract_select_insert_negative(ptr %p1, i64 %v) {
+; CHECK-LABEL: define i64 @test_extract_select_insert_negative(
+; CHECK-SAME: ptr [[P1:%.*]], i64 [[V:%.*]]) {
+; CHECK-NEXT:    [[CALL:%.*]] = call { ptr, i64 } @foo()
+; CHECK-NEXT:    [[CALL2:%.*]] = call { ptr, i64 } @foo()
+; CHECK-NEXT:    [[ELM1:%.*]] = extractvalue { ptr, i64 } [[CALL]], 1
+; CHECK-NEXT:    [[CMP:%.*]] = icmp eq i64 [[ELM1]], [[V]]
+; CHECK-NEXT:    [[FCA1:%.*]] = insertvalue { ptr, i64 } [[CALL2]], ptr [[P1]], 0
+; CHECK-NEXT:    [[SELECT:%.*]] = select i1 [[CMP]], { ptr, i64 } [[CALL]], { ptr, i64 } [[FCA1]]
+; CHECK-NEXT:    [[RES:%.*]] = extractvalue { ptr, i64 } [[SELECT]], 1
+; CHECK-NEXT:    ret i64 [[RES]]
+;
+  %call = call { ptr, i64 } @foo()
+  %call2 = call { ptr, i64 } @foo()
+  %elm1 = extractvalue { ptr, i64 } %call, 1
+  %cmp = icmp eq i64 %elm1, %v
+  %fca1 = insertvalue { ptr, i64 } %call2, ptr %p1, 0
+  %select = select i1 %cmp, { ptr, i64 } %call, { ptr, i64 } %fca1
+  %res = extractvalue { ptr, i64 } %select, 1
+  ret i64 %res
+}
+
 declare { ptr, i64 } @foo()