formatting

Author: oontvoo

lldb/include/lldb/Core/Telemetry.h

@@ -26,10 +26,10 @@
 #include <optional>
 #include <string>
 
-#include <unordered_map>
+#include <functional>
 #include <type_traits>
+#include <unordered_map>
 #include <utility>
-#include <functional>
 
 namespace lldb_private {
 namespace telemetry {
@@ -41,7 +41,8 @@ namespace telemetry {
 //  - First two bits (MSB) must be 11 - the common prefix
 //  - Last two bits (LSB) are reserved for grand-children of LLDBTelemetryInfo
 // If any of the subclass has descendents, those descendents
-// must have their LLDBEntryKind in the similar form (ie., share common prefix and differ by the last two bits)
+// must have their LLDBEntryKind in the similar form (ie., share common prefix
+// and differ by the last two bits)
 struct LLDBEntryKind : public ::llvm::telemetry::EntryKind {
   static const llvm::telemetry::KindType BaseInfo = 0b11000000;
   static const llvm::telemetry::KindType DebuggerInfo = 0b11000100;
@@ -87,17 +88,21 @@ struct TargetInfo : public LLDBBaseTelemetryInfo {
   std::string target_uuid;
   std::string arch_name;
 
-  // If true, this entry was emitted at the beginning of an event (eg., before the executable laod). Otherwise, it was emitted at the end of an event (eg., after the module and any dependency were loaded.)
+  // If true, this entry was emitted at the beginning of an event (eg., before
+  // the executable laod). Otherwise, it was emitted at the end of an event
+  // (eg., after the module and any dependency were loaded.)
   bool is_start_entry;
 
   // Describes the exit of the executable module.
   std::optional<ExitDescription> exit_desc;
   TargetInfo() = default;
 
-  llvm::telemetry::KindType getKind() const override { return LLDBEntryKind::TargetInfo; }
+  llvm::telemetry::KindType getKind() const override {
+    return LLDBEntryKind::TargetInfo;
+  }
 
   static bool classof(const TelemetryInfo *T) {
-   // Subclasses of this is also acceptable
+    // Subclasses of this is also acceptable
     return (T->getKind() & LLDBEntryKind::TargetInfo) ==
            LLDBEntryKind::TargetInfo;
   }
@@ -141,7 +146,7 @@ class TelemetryManager : public llvm::telemetry::Manager {
   /// during the action.
   ///
   /// Invoked at the begining of the load of the main-executable.
-  virtual void AtMainExecutableLoadStart(TargetInfo * entry);
+  virtual void AtMainExecutableLoadStart(TargetInfo *entry);
   /// Invoked at the end of the load.
   virtual void AtMainExecutableLoadEnd(TargetInfo *entry);
 

lldb/source/Target/Process.cpp

@@ -1065,12 +1065,13 @@ const char *Process::GetExitDescription() {
 bool Process::SetExitStatus(int status, llvm::StringRef exit_string) {
   // Use a mutex to protect setting the exit status.
   std::lock_guard<std::mutex> guard(m_exit_status_mutex);
-  Debugger* debugger = &(GetTarget().GetDebugger());
-  telemetry::ScopedDispatch<telemetry::TargetInfo> helper (debugger);
+  Debugger *debugger = &(GetTarget().GetDebugger());
+  telemetry::ScopedDispatch<telemetry::TargetInfo> helper(debugger);
   // Save the Module UUID since the Module might be gone by end of scope.
-  std::string target_uuid = GetTarget().GetExecutableModule()->GetUUID().GetAsString();
+  std::string target_uuid =
+      GetTarget().GetExecutableModule()->GetUUID().GetAsString();
 
-  helper.DispatchNow([&](telemetry::TargetInfo *info){
+  helper.DispatchNow([&](telemetry::TargetInfo *info) {
     info->target_uuid = target_uuid;
     info->is_start_entry = true;
   });

lldb/source/Target/Target.cpp

@@ -20,11 +20,11 @@
 #include "lldb/Core/Module.h"
 #include "lldb/Core/ModuleSpec.h"
 #include "lldb/Core/PluginManager.h"
-#include "lldb/Core/Telemetry.h"
 #include "lldb/Core/SearchFilter.h"
 #include "lldb/Core/Section.h"
 #include "lldb/Core/SourceManager.h"
 #include "lldb/Core/StructuredDataImpl.h"
+#include "lldb/Core/Telemetry.h"
 #include "lldb/DataFormatters/FormatterSection.h"
 #include "lldb/Expression/DiagnosticManager.h"
 #include "lldb/Expression/ExpressionVariable.h"
@@ -1575,7 +1575,6 @@ void Target::SetExecutableModule(ModuleSP &executable_sp,
     helper.DispatchOnExit([&](telemetry::TargetInfo *info) {
       info->exec_mod = executable_sp;
       info->target_uuid = executable_sp->GetUUID().GetAsString();
-
     });
 
     ElapsedTime elapsed(m_stats.GetCreateTime());