Add comment explaining templates

fsfod · fsfod · commit f4a4661fc48a · 2024-10-23T17:52:08.000+01:00
diff --git a/llvm/include/llvm/SandboxIR/Constant.h b/llvm/include/llvm/SandboxIR/Constant.h
@@ -798,6 +798,7 @@ class GlobalWithNodeAPI : public ParentT {
   }
 };
 
+// These are needed for SandboxIRTest when building with LLVM_BUILD_LLVM_DYLIB
 extern template LLVM_TEMPLATE_ABI GlobalIFunc &
 GlobalWithNodeAPI<GlobalIFunc, llvm::GlobalIFunc, GlobalObject,
                   llvm::GlobalObject>::LLVMGVToGV::operator()(llvm::GlobalIFunc
diff --git a/llvm/lib/SandboxIR/Constant.cpp b/llvm/lib/SandboxIR/Constant.cpp
@@ -302,6 +302,7 @@ template class GlobalWithNodeAPI<GlobalVariable, llvm::GlobalVariable,
 template class GlobalWithNodeAPI<GlobalAlias, llvm::GlobalAlias, GlobalValue,
                                  llvm::GlobalValue>;
 
+// These are needed for SandboxIRTest when building with LLVM_BUILD_LLVM_DYLIB
 template LLVM_EXPORT_TEMPLATE GlobalIFunc &
 GlobalWithNodeAPI<GlobalIFunc, llvm::GlobalIFunc, GlobalObject,
                   llvm::GlobalObject>::LLVMGVToGV::operator()(llvm::GlobalIFunc

Original file line number	Diff line number	Diff line change
`@@ -798,6 +798,7 @@ class GlobalWithNodeAPI : public ParentT {`
`798`	`798`	`}`
`799`	`799`	`};`
`800`	`800`
	`801`	`+// These are needed for SandboxIRTest when building with LLVM_BUILD_LLVM_DYLIB`
`801`	`802`	`extern template LLVM_TEMPLATE_ABI GlobalIFunc &`
`802`	`803`	`GlobalWithNodeAPI<GlobalIFunc, llvm::GlobalIFunc, GlobalObject,`
`803`	`804`	`llvm::GlobalObject>::LLVMGVToGV::operator()(llvm::GlobalIFunc`