Skip to content

Commit f4b94ca

Browse files
inbelicIcohedron
andauthored
review: touch up comments
Co-authored-by: Deric C. <[email protected]>
1 parent a3240de commit f4b94ca

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

llvm/lib/Frontend/HLSL/HLSLRootSignature.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ std::optional<const RangeInfo *> ResourceRange::insert(const RangeInfo &Info) {
250250
break;
251251

252252
// Let Interval = [x;y] and [LowerBound;UpperBound] = [a;b] and note that
253-
// a <= y implicitly from Intervals.find(LowerBound)
253+
// a <= y implicitly from Interval.advanceTo(LowerBound)
254254
if (UpperBound < Interval.start())
255255
break; // found interval does not overlap with inserted one
256256

@@ -272,7 +272,7 @@ std::optional<const RangeInfo *> ResourceRange::insert(const RangeInfo &Info) {
272272
// -> so set b = x - 1 such that [a;x-1] is now the interval to insert
273273
UpperBound = Interval.start() - 1;
274274
} else if (Interval.start() <= LowerBound && Interval.stop() < UpperBound) {
275-
// a < x <= b <= y implies that [y; b] is not covered but [a;y] is
275+
// x <= a <= y < b implies that [y; b] is not covered but [a;y] is
276276
// -> so set a = y + 1 such that [y+1;b] is now the interval to insert
277277
LowerBound = Interval.stop() + 1;
278278
}

llvm/unittests/Frontend/HLSLRootSignatureRangesTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ TEST(HLSLRootSignatureTest, SingleOverlappingInsertTests) {
8484
// B = [0;0]
8585
EXPECT_EQ(Range.lookup(0), &B);
8686

87-
// C = [6; unbounded]
87+
// C = [6;unbounded]
8888
EXPECT_EQ(Range.lookup(6), &C);
8989
EXPECT_EQ(Range.lookup(RangeInfo::Unbounded), &C);
9090
}

0 commit comments

Comments
 (0)