minor tweeks

Author: akuhlens

flang/include/flang/Support/Fortran-features.h

@@ -126,10 +126,10 @@ class LanguageFeatureControl {
   bool ShouldWarn(UsageWarning w) const { return warnUsage_.test(w); }
   // Cli options
   // Find a warning by its Cli spelling, i.e. '[no-]warning-name'.
-  std::optional<WarningAndEnabled> FindWarning(std::string input);
+  std::optional<WarningAndEnabled> FindWarning(std::string_view input);
   // Take a string from the Cli and apply it to the LanguageFeatureControl.
   // Return true if the option was recognized (and hence applied).
-  bool EnableWarning(std::string input);
+  bool EnableWarning(std::string_view input);
   // The add and replace functions are not currently used but are provided
   // to allow a flexible many-to-one mapping from Cli spellings to enum values.
   // Taking a string by value because the functions own this string after the

flang/lib/Support/Fortran-features.cpp

@@ -152,19 +152,19 @@ LanguageFeatureControl::LanguageFeatureControl() {
 }
 
 std::optional<std::pair<Warning, bool>> LanguageFeatureControl::FindWarning(
-    std::string input) {
+    std::string_view input) {
   bool negated{false};
   if (input.size() > 3 && input.substr(0, 3) == "no-") {
     negated = true;
     input = input.substr(3);
   }
-  if (auto it{cliOptions_.find(input)}; it != cliOptions_.end()) {
+  if (auto it{cliOptions_.find(std::string{input})}; it != cliOptions_.end()) {
     return std::make_pair(it->second, !negated);
   }
   return std::nullopt;
 }
 
-bool LanguageFeatureControl::EnableWarning(std::string input) {
+bool LanguageFeatureControl::EnableWarning(std::string_view input) {
   if (auto warningAndEnabled{FindWarning(input)}) {
     EnableWarning(warningAndEnabled->first, warningAndEnabled->second);
     return true;