Require source be in success state before copying

kastiglione · kastiglione · commit f506bff7d69f · 2025-03-15T10:52:44.000-07:00
diff --git a/lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp b/lldb/source/ValueObject/ValueObjectSyntheticFilter.cpp
@@ -362,7 +362,8 @@ lldb::ValueObjectSP ValueObjectSynthetic::GetNonSyntheticValue() {
 }
 
 void ValueObjectSynthetic::CopyValueData(ValueObject *source) {
-  source->UpdateValueIfNeeded();
+  if (!source->UpdateValueIfNeeded())
+    return;
   m_value = source->GetValue();
   ExecutionContext exe_ctx(GetExecutionContextRef());
   m_error = m_value.GetValueAsData(&exe_ctx, m_data, GetModule().get());

Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,8 @@ lldb::ValueObjectSP ValueObjectSynthetic::GetNonSyntheticValue() {`
`362`	`362`	`}`
`363`	`363`
`364`	`364`	`void ValueObjectSynthetic::CopyValueData(ValueObject *source) {`
`365`		`- source->UpdateValueIfNeeded();`
	`365`	`+ if (!source->UpdateValueIfNeeded())`
	`366`	`+ return;`
`366`	`367`	`m_value = source->GetValue();`
`367`	`368`	`ExecutionContext exe_ctx(GetExecutionContextRef());`
`368`	`369`	`m_error = m_value.GetValueAsData(&exe_ctx, m_data, GetModule().get());`