Address review feedback

Author: spavloff

clang/docs/ReleaseNotes.rst

@@ -705,7 +705,7 @@ Improvements to Clang's diagnostics
 - Clang now does not issue a warning about returning from a function declared with
   the ``[[noreturn]]`` attribute when the function body is ended with a call via
   pointer, provided it can be proven that the pointer only points to
-  ``[[noreturn]]`` functions..
+  ``[[noreturn]]`` functions.
 
 Improvements to Clang's time-trace
 ----------------------------------

clang/lib/Sema/AnalysisBasedWarnings.cpp

@@ -403,29 +403,27 @@ static bool isNoexcept(const FunctionDecl *FD) {
   return false;
 }
 
+/// Checks if the given expression is a reference to a function with
+/// 'noreturn' attribute.
+static bool isReferenceToNoReturn(const Expr *E) {
+  if (auto *DRef = dyn_cast<DeclRefExpr>(E->IgnoreParenCasts()))
+    if (auto *FD = dyn_cast<FunctionDecl>(DRef->getDecl()))
+      return FD->isNoReturn();
+  return false;
+}
+
 /// Checks if the given variable, which is assumed to be a function pointer, is
 /// initialized with a function having 'noreturn' attribute.
 static bool isInitializedWithNoReturn(const VarDecl *VD) {
   if (const Expr *Init = VD->getInit()) {
     if (auto *ListInit = dyn_cast<InitListExpr>(Init);
         ListInit && ListInit->getNumInits() > 0)
       Init = ListInit->getInit(0);
-    if (auto *DeclRef = dyn_cast<DeclRefExpr>(Init->IgnoreParenCasts()))
-      if (auto *FD = dyn_cast<FunctionDecl>(DeclRef->getDecl()))
-        return FD->isNoReturn();
+    return isReferenceToNoReturn(Init);
   }
   return false;
 }
 
-/// Checks if the given expression is a reference to a function with
-/// 'noreturn' attribute.
-static bool isReferenceToNoReturn(const Expr *E) {
-  if (auto *DRef = dyn_cast<DeclRefExpr>(E->IgnoreParenCasts()))
-    if (auto *FD = dyn_cast<FunctionDecl>(DRef->getDecl()))
-      return FD->isNoReturn();
-  return false;
-}
-
 namespace {
 
 /// Looks for statements, that can define value of the given variable.