Removed ModuleSP

DhruvSrivastavaX · DhruvSrivastavaX · commit f5c008aaef3b · 2024-12-18T04:23:58.000-06:00
diff --git a/lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp b/lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp
@@ -104,7 +104,6 @@ bool ObjectFileXCOFF::CreateBinary() {
                    "Failed to create binary for file ({1}): {0}", m_file);
     return false;
   }
-
   // Make sure we only handle XCOFF format.
   m_binary =
       llvm::unique_dyn_cast<llvm::object::XCOFFObjectFile>(std::move(*binary));
@@ -170,9 +169,8 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP &data_sp,
 }
 
 bool ObjectFileXCOFF::ParseHeader() {
-  ModuleSP module_sp(GetModule());
   // Only 64-bit is supported for now
-  return module_sp && m_binary->fileHeader64()->Magic == XCOFF::XCOFF64;
+  return m_binary->fileHeader64()->Magic == XCOFF::XCOFF64;
 }
 
 ByteOrder ObjectFileXCOFF::GetByteOrder() const { return eByteOrderBig; }

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,6 @@ bool ObjectFileXCOFF::CreateBinary() {`
`104`	`104`	`"Failed to create binary for file ({1}): {0}", m_file);`
`105`	`105`	`return false;`
`106`	`106`	`}`
`107`		`-`
`108`	`107`	`// Make sure we only handle XCOFF format.`
`109`	`108`	`m_binary =`
`110`	`109`	`llvm::unique_dyn_cast<llvm::object::XCOFFObjectFile>(std::move(*binary));`
`@@ -170,9 +169,8 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP &data_sp,`
`170`	`169`	`}`
`171`	`170`
`172`	`171`	`bool ObjectFileXCOFF::ParseHeader() {`
`173`		`- ModuleSP module_sp(GetModule());`
`174`	`172`	`// Only 64-bit is supported for now`
`175`		`- return module_sp && m_binary->fileHeader64()->Magic == XCOFF::XCOFF64;`
	`173`	`+ return m_binary->fileHeader64()->Magic == XCOFF::XCOFF64;`
`176`	`174`	`}`
`177`	`175`
`178`	`176`	`ByteOrder ObjectFileXCOFF::GetByteOrder() const { return eByteOrderBig; }`