Remove instruction start

Author: jakeegan

compiler-rt/lib/sanitizer_common/sanitizer_aix.h

@@ -23,12 +23,6 @@ struct prmap;
 
 namespace __sanitizer {
 
-#  if SANITIZER_WORDSIZE == 32
-static const uptr InstructionStart = 0x10000000;
-#  else
-static const uptr InstructionStart = 0x100000000;
-#  endif
-
 struct ProcSelfMapsBuff {
   char *data;
   uptr mmaped_size;

compiler-rt/lib/sanitizer_common/sanitizer_common.h

@@ -835,8 +835,7 @@ class LoadedModule {
         max_address_(0),
         arch_(kModuleArchUnknown),
         uuid_size_(0),
-        instrumented_(false),
-        instr_start_(0) {
+        instrumented_(false) {
     internal_memset(uuid_, 0, kModuleUUIDSize);
     ranges_.clear();
   }
@@ -856,8 +855,6 @@ class LoadedModule {
   const u8 *uuid() const { return uuid_; }
   uptr uuid_size() const { return uuid_size_; }
   bool instrumented() const { return instrumented_; }
-  uptr get_instr_start() const { return instr_start_; }
-  void set_instr_start(uptr start) { instr_start_ = start; }
 
   struct AddressRange {
     AddressRange *next;
@@ -888,7 +885,6 @@ class LoadedModule {
   uptr uuid_size_;
   u8 uuid_[kModuleUUIDSize];
   bool instrumented_;
-  uptr instr_start_;
   IntrusiveList<AddressRange> ranges_;
 };
 

compiler-rt/lib/sanitizer_common/sanitizer_procmaps_common.cpp

@@ -152,11 +152,6 @@ void MemoryMappingLayout::DumpListOfModules(
     uptr base_address = (i ? segment.start : 0) - segment.offset;
     LoadedModule cur_module;
     cur_module.set(cur_name, base_address);
-#  if SANITIZER_AIX
-    // Instructions in AIX shared libraries don't start 0x0.
-    if (segment.IsShared() && segment.IsExecutable())
-      cur_module.set_instr_start(InstructionStart);
-#  endif
     segment.AddAddressRanges(&cur_module);
     modules->push_back(cur_module);
   }

compiler-rt/lib/sanitizer_common/sanitizer_symbolizer.cpp

@@ -46,10 +46,7 @@ void AddressInfo::FillModuleInfo(const char *mod_name, uptr mod_offset,
 
 void AddressInfo::FillModuleInfo(const LoadedModule &mod) {
   module = internal_strdup(mod.full_name());
-  // On some platforms, like on AIX, the first instructions does not start from
-  // 0x0, we need to addd the start back to get correct instruction offset in
-  // the objects.
-  module_offset = address - mod.base_address() + mod.get_instr_start();
+  module_offset = address - mod.base_address();
   module_arch = mod.arch();
   if (mod.uuid_size())
     internal_memcpy(uuid, mod.uuid(), mod.uuid_size());