Skip to content

Commit f71919b

Browse files
author
George Hu
committed
Address comment
1 parent 49fe236 commit f71919b

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

lldb/include/lldb/API/SBModuleSpec.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,12 @@ class LLDB_API SBModuleSpec {
8989

9090
lldb::SBTarget GetTarget();
9191

92+
/// Set the target to be used when resolving a module.
93+
///
94+
/// A target can help locate a module specified by a SBModuleSpec. The
95+
/// target settings, like the executable and debug info search paths, can
96+
/// be essential. The target's platform can also be used to locate or download
97+
/// the specified module.
9298
void SetTarget(lldb::SBTarget target);
9399

94100
private:

lldb/include/lldb/Core/ModuleSpec.h

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,14 @@ class ModuleSpec {
128128

129129
lldb::DataBufferSP GetData() const { return m_data; }
130130

131-
lldb::TargetSP GetTargetSP() { return m_target_wp.lock(); }
132-
133131
lldb::TargetSP GetTargetSP() const { return m_target_wp.lock(); }
134132

133+
/// Set the target to be used when resolving a module.
134+
///
135+
/// A target can help locate a module specified by a ModuleSpec. The target
136+
/// settings, like the executable and debug info search paths, can be
137+
/// essential. The target's platform can also be used to locate or download
138+
/// the specified module.
135139
void SetTarget(std::shared_ptr<Target> target) { m_target_wp = target; }
136140

137141
void Clear() {
@@ -274,8 +278,10 @@ class ModuleSpec {
274278
ArchSpec m_arch;
275279
UUID m_uuid;
276280
ConstString m_object_name;
277-
/// This is set to take advantage of the target's search path and platform's
278-
/// locate module callback
281+
/// The target used when resolving a module. A target can help locate a module
282+
/// specified by a ModuleSpec. The target settings, like the executable and
283+
/// debug info search paths, can be essential. The target's platform can also
284+
/// be used to locate or download the specified module.
279285
std::weak_ptr<Target> m_target_wp;
280286
uint64_t m_object_offset = 0;
281287
uint64_t m_object_size = 0;

0 commit comments

Comments
 (0)