Skip to content

Commit f74c5ea

Browse files
committed
Remove C++ test. Try to get along with only a 'TypeAttr' instead of 'DeclOrTypeAttr'.
1 parent 514523b commit f74c5ea

File tree

2 files changed

+1
-27
lines changed

2 files changed

+1
-27
lines changed

clang/include/clang/Basic/Attr.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3929,7 +3929,7 @@ def CFICanonicalJumpTable : InheritableAttr {
39293929
let SimpleHandler = 1;
39303930
}
39313931

3932-
def CFISalt : DeclOrTypeAttr {
3932+
def CFISalt : TypeAttr {
39333933
let Spellings = [Clang<"cfi_salt">];
39343934
let Args = [StringArgument<"Salt">];
39353935
let Subjects = SubjectList<[Function, Field, Var, TypedefName], ErrorDiag>;

clang/test/CodeGen/cfi-salt.c

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -153,29 +153,6 @@ static int f5_salt(void) __cfi_salt { return 2; }
153153
int f7_salt(struct cfi_struct *ptr) { return ptr->fptr(); }
154154
int f7_typedef_salt(struct cfi_struct *ptr) { return ptr->td_fptr(); }
155155

156-
#ifdef __cplusplus
157-
// MEMBER-LABEL: define dso_local void @_Z16test_member_callv() #0 !kcfi_type
158-
// MEMBER: call void %[[#]](ptr{{.*}} [ "kcfi"(i32 [[#%d,MEMBER_LOW_SODIUM_HASH:]]) ]
159-
// MEMBER: call void %[[#]](ptr{{.*}} [ "kcfi"(i32 [[#%d,MEMBER_SALT_HASH:]]) ]
160-
161-
// MEMBER-LABEL: define{{.*}} void @_ZN1A1fEv(ptr{{.*}} %this){{.*}} !kcfi_type
162-
// MEMBER-SAME: [[#MEMBER_LOW_SODIUM_TYPE:]]
163-
// MEMBER-LABEL: define{{.*}} void @_ZN1A1gEv(ptr{{.*}} %this){{.*}} !kcfi_type
164-
// MEMBER-SAME: [[#MEMBER_SALT_TYPE:]]
165-
struct A {
166-
void f() {}
167-
void __cfi_salt g() {}
168-
};
169-
170-
void test_member_call(void) {
171-
void (A::* p)() = &A::f;
172-
(A().*p)();
173-
174-
void __cfi_salt (A::* q)() = &A::g;
175-
(A().*q)();
176-
}
177-
#endif
178-
179156
// CHECK: ![[#]] = !{i32 4, !"kcfi", i32 1}
180157
// OFFSET: ![[#]] = !{i32 4, !"kcfi-offset", i32 3}
181158
//
@@ -184,6 +161,3 @@ void test_member_call(void) {
184161
//
185162
// CHECK: ![[#LOW_SODIUM_UTYPE]] = !{i32 [[#LOW_SODIUM_UHASH]]}
186163
// CHECK: ![[#SALTY_UTYPE]] = !{i32 [[#SALTY_UHASH]]}
187-
//
188-
// MEMBER: ![[#MEMBER_LOW_SODIUM_TYPE]] = !{i32 [[#MEMBER_LOW_SODIUM_HASH]]}
189-
// MEMBER: ![[#MEMBER_SALT_TYPE]] = !{i32 [[#MEMBER_SALT_HASH]]}

0 commit comments

Comments
 (0)