Skip to content

Commit f797c34

Browse files
committed
address dinistro review
1 parent 652a83d commit f797c34

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1594,7 +1594,7 @@ def LLVM_DSOLocalEquivalentOp : LLVM_Op<"dso_local_equivalent",
15941594
llvm.mlir.global external constant @const() : i64 {
15951595
%0 = llvm.mlir.addressof @const : !llvm.ptr
15961596
%1 = llvm.ptrtoint %0 : !llvm.ptr to i64
1597-
%2 = llvm.dso_local_equivalent @extern_func : !llvm.ptr
1597+
%2 = llvm.dso_local_equivalent @func : !llvm.ptr
15981598
%4 = llvm.ptrtoint %2 : !llvm.ptr to i64
15991599
llvm.return %4 : i64
16001600
}

mlir/test/Target/LLVMIR/llvmir-invalid.mlir

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -430,11 +430,11 @@ llvm.func @call_alias_func() {
430430

431431
// -----
432432

433-
llvm.mlir.global external @zed() : !llvm.ptr
433+
llvm.mlir.global external @y() : !llvm.ptr
434434

435435
llvm.func @call_alias_func() {
436436
// expected-error @below{{op must reference a global defined by 'llvm.func' or 'llvm.mlir.alias'}}
437-
%0 = llvm.dso_local_equivalent @foo : !llvm.ptr
437+
%0 = llvm.dso_local_equivalent @y : !llvm.ptr
438438
llvm.call %0() : !llvm.ptr, () -> (i32)
439439
llvm.return
440440
}

0 commit comments

Comments
 (0)