Skip to content

Commit f7c9c8f

Browse files
author
Doug Wyatt
committed
Release note, clang-format.
1 parent 81acc83 commit f7c9c8f

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -707,6 +707,12 @@ Improvements to Clang's diagnostics
707707
- Improve the diagnostics for placement new expression when const-qualified
708708
object was passed as the storage argument. (#GH143708)
709709

710+
- Added a separate diagnostic group `-Wfunction-effect-redeclarations``, for the more pedantic
711+
diagnostics for function effects (``[[clang::nonblocking]]`` and ``[[clang::nonallocating]]``).
712+
Moved the warning for a missing (though implied) attribute on a redeclaration into this group.
713+
Added a new warning in this group for the case where the attribute is missing/implicit on
714+
an override of a virtual method.
715+
710716
Improvements to Clang's time-trace
711717
----------------------------------
712718

clang/lib/Sema/SemaDeclCXX.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18700,8 +18700,8 @@ bool Sema::CheckOverridingFunctionAttributes(CXXMethodDecl *New,
1870018700
NewFT->getParamTypes(), EPI);
1870118701
New->setType(ModQT);
1870218702
if (Errs.empty()) {
18703-
// A warning here is somewhat pedantic. Skip this if there was already
18704-
// a merge conflict, which is more serious.
18703+
// A warning here is somewhat pedantic. Skip this if there was
18704+
// already a merge conflict, which is more serious.
1870518705
Diag(New->getLocation(), diag::warn_mismatched_func_effect_override)
1870618706
<< Diff.effectName();
1870718707
Diag(Old->getLocation(), diag::note_overridden_virtual_function)

0 commit comments

Comments
 (0)