Addressing review feedbacks

Author: jerryyin

mlir/include/mlir/Conversion/Passes.td

@@ -1340,7 +1340,7 @@ def ConvertVectorToArmSMEPass : Pass<"convert-vector-to-arm-sme"> {
 def ConvertVectorToAMDGPUPass : Pass<"convert-vector-to-amdgpu"> {
   let summary = "Lower the operations from the vector dialect into the AMDGPU "
                 "dialect";
-  let dependentDialects = ["amdgpu::AMDGPUDialect", "vector::VectorDialect"];
+  let dependentDialects = ["vector::VectorDialect"];
 } 
 
 //===----------------------------------------------------------------------===//

mlir/lib/Conversion/VectorToAMDGPU/VectorToAMDGPU.cpp

@@ -97,6 +97,8 @@ static LogicalResult transferPreconditions(
   return success();
 }
 
+namespace {
+
 struct TransferReadLowering final : OpRewritePattern<vector::TransferReadOp> {
   using OpRewritePattern::OpRewritePattern;
 
@@ -130,13 +132,15 @@ struct TransferReadLowering final : OpRewritePattern<vector::TransferReadOp> {
   }
 };
 
+} // namespace
+
 void mlir::populateVectorToAMDGPUConversionPatterns(
     RewritePatternSet &patterns) {
   patterns.add<TransferReadLowering>(patterns.getContext());
 }
 
 struct ConvertVectorToAMDGPUPass final
-    : public impl::ConvertVectorToAMDGPUPassBase<ConvertVectorToAMDGPUPass> {
+    : impl::ConvertVectorToAMDGPUPassBase<ConvertVectorToAMDGPUPass> {
   void runOnOperation() override {
     RewritePatternSet patterns(&getContext());
     populateVectorToAMDGPUConversionPatterns(patterns);