Skip to content

Commit f814446

Browse files
committed
[lldb][AArch64][test] Require SVE for some Linux tests
These tests had only ever been run on SVE or SVE+SME systems. While investigating #138717 I found they failed on an SME only system. This happens because before the first stop we try to initialise SVE registers while outside of streaming mode. Which causes a SIGILL. To fix this, require SVE to be present. I could go in and make these work on SME only, but it's more complex and I will be adding SME only specific tests in future anyway.
1 parent 9a51879 commit f814446

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,9 @@ def setup_register_config_test(self, run_args=None):
9797
@skipIf(oslist=no_match(["linux"]))
9898
def test_aarch64_dynamic_regset_config(self):
9999
"""Test AArch64 Dynamic Register sets configuration."""
100+
if not self.isAArch64SVE():
101+
self.skipTest("SVE must be present")
102+
100103
register_sets = self.setup_register_config_test()
101104

102105
for registerSet in register_sets:
@@ -259,6 +262,8 @@ def write_to_enable_za_test(self, has_zt0, write_za_first):
259262
def test_aarch64_dynamic_regset_config_sme_write_za_to_enable(self):
260263
"""Test that ZA and ZT0 (if present) shows as 0s when disabled and
261264
can be enabled by writing to ZA."""
265+
if not self.isAArch64SVE():
266+
self.skipTest("SVE must be present.")
262267
if not self.isAArch64SME():
263268
self.skipTest("SME must be present.")
264269

@@ -270,6 +275,8 @@ def test_aarch64_dynamic_regset_config_sme_write_za_to_enable(self):
270275
def test_aarch64_dynamic_regset_config_sme_write_zt0_to_enable(self):
271276
"""Test that ZA and ZT0 (if present) shows as 0s when disabled and
272277
can be enabled by writing to ZT0."""
278+
if not self.isAArch64SVE():
279+
self.skipTest("SVE must be present.")
273280
if not self.isAArch64SME():
274281
self.skipTest("SME must be present.")
275282
if not self.isAArch64SME2():

0 commit comments

Comments
 (0)