review: add assert

inbelic · inbelic · commit f8ff016249b3 · 2025-08-21T11:54:32.000-07:00
diff --git a/clang/lib/Driver/ToolChains/HLSL.cpp b/clang/lib/Driver/ToolChains/HLSL.cpp
@@ -315,6 +315,8 @@ void tools::LLVMObjcopy::ConstructJob(Compilation &C, const JobAction &JA,
     CmdArgs.push_back(Frs);
   }
 
+  assert(CmdArgs.size() > 2 && "Unnecessary invocation of objcopy.");
+
   C.addCommand(std::make_unique<Command>(JA, *this, ResponseFileSupport::None(),
                                          Exec, CmdArgs, Inputs, Input));
 }

Original file line number	Diff line number	Diff line change
`@@ -315,6 +315,8 @@ void tools::LLVMObjcopy::ConstructJob(Compilation &C, const JobAction &JA,`
`315`	`315`	`CmdArgs.push_back(Frs);`
`316`	`316`	`}`
`317`	`317`
	`318`	`+ assert(CmdArgs.size() > 2 && "Unnecessary invocation of objcopy.");`
	`319`	`+`
`318`	`320`	`C.addCommand(std::make_unique<Command>(JA, *this, ResponseFileSupport::None(),`
`319`	`321`	`Exec, CmdArgs, Inputs, Input));`
`320`	`322`	`}`