Skip to content

Commit f905090

Browse files
committed
address comment
1 parent a9f0e58 commit f905090

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

llvm/include/llvm/CodeGen/SelectionDAG.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1130,8 +1130,8 @@ class SelectionDAG {
11301130
return getNode(ISD::UNDEF, SDLoc(), VT);
11311131
}
11321132

1133-
/// Return an POISON node. POISON does not have a useful SDLoc.
1134-
SDValue getPoison(EVT VT) { return getNode(ISD::POISON, SDLoc(), VT); }
1133+
/// Return a POISON node. POISON does not have a useful SDLoc.
1134+
SDValue getPOISON(EVT VT) { return getNode(ISD::POISON, SDLoc(), VT); }
11351135

11361136
/// Return a node that represents the runtime scaling 'MulImm * RuntimeVL'.
11371137
SDValue getVScale(const SDLoc &DL, EVT VT, APInt MulImm,

llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -984,7 +984,7 @@ void SelectionDAGLegalize::LegalizeOp(SDNode *Node) {
984984
// Additionally, many existing test cases rely on the current behavior (e.g.,
985985
// llvm/test/CodeGen/PowerPC/vec_shuffle.ll). A broader discussion and
986986
// incremental changes might be needed to properly
987-
// support POISON without breaking existing targets and tests.
987+
// support POISON without breaking existing targets and tests.
988988
case ISD::POISON: {
989989
SDValue UndefNode = DAG.getUNDEF(Node->getValueType(0));
990990
ReplaceNode(Node, UndefNode.getNode());

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9203,7 +9203,6 @@ SDValue SelectionDAG::getLoad(ISD::MemIndexedMode AM, ISD::LoadExtType ExtType,
92039203

92049204
SDVTList VTs = Indexed ?
92059205
getVTList(VT, Ptr.getValueType(), MVT::Other) : getVTList(VT, MVT::Other);
9206-
92079206
SDValue Ops[] = { Chain, Ptr, Offset };
92089207
FoldingSetNodeID ID;
92099208
AddNodeIDNode(ID, ISD::LOAD, VTs, Ops);

llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1817,7 +1817,7 @@ SDValue SelectionDAGBuilder::getValueImpl(const Value *V) {
18171817
return DAG.getConstantFP(*CFP, getCurSDLoc(), VT);
18181818

18191819
if (isa<UndefValue>(C) && !V->getType()->isAggregateType())
1820-
return isa<PoisonValue>(C) ? DAG.getPoison(VT) : DAG.getUNDEF(VT);
1820+
return isa<PoisonValue>(C) ? DAG.getPOISON(VT) : DAG.getUNDEF(VT);
18211821

18221822
if (const ConstantExpr *CE = dyn_cast<ConstantExpr>(C)) {
18231823
visit(CE->getOpcode(), *CE);

0 commit comments

Comments
 (0)