comparison of unsigned expression in ‘>= 0’ is always true

hiraditya · hiraditya · commit f90caa916850 · 2025-03-11T14:36:22.000-07:00
diff --git a/llvm/lib/IR/AutoUpgrade.cpp b/llvm/lib/IR/AutoUpgrade.cpp
@@ -5044,7 +5044,7 @@ static void upgradeNVVMFnVectorAttr(const StringRef Attr, const char DimC,
   }
 
   const unsigned Dim = DimC - 'x';
-  assert(Dim >= 0 && Dim < 3 && "Unexpected dim char");
+  assert(Dim < 3 && "Unexpected dim char");
 
   const uint64_t VInt = mdconst::extract<ConstantInt>(V)->getZExtValue();
 

Original file line number	Diff line number	Diff line change
`@@ -5044,7 +5044,7 @@ static void upgradeNVVMFnVectorAttr(const StringRef Attr, const char DimC,`
`5044`	`5044`	`}`
`5045`	`5045`
`5046`	`5046`	`const unsigned Dim = DimC - 'x';`
`5047`		`- assert(Dim >= 0 && Dim < 3 && "Unexpected dim char");`
	`5047`	`+ assert(Dim < 3 && "Unexpected dim char");`
`5048`	`5048`
`5049`	`5049`	`const uint64_t VInt = mdconst::extract<ConstantInt>(V)->getZExtValue();`
`5050`	`5050`