review fixes

Author: Hardcode84

mlir/lib/Dialect/Arith/IR/InferIntRangeInterfaceImpls.cpp

@@ -35,26 +35,21 @@ convertArithOverflowFlags(arith::IntegerOverflowFlags flags) {
 
 void arith::ConstantOp::inferResultRanges(ArrayRef<ConstantIntRanges> argRanges,
                                           SetIntRangeFn setResultRange) {
-  if (auto constAttr = llvm::dyn_cast_or_null<IntegerAttr>(getValue())) {
-    const APInt &value = constAttr.getValue();
+  if (auto scalarCstAttr = llvm::dyn_cast_or_null<IntegerAttr>(getValue())) {
+    const APInt &value = scalarCstAttr.getValue();
     setResultRange(getResult(), ConstantIntRanges::constant(value));
     return;
   }
-  if (auto constAttr =
+  if (auto arrayCstAttr =
           llvm::dyn_cast_or_null<DenseIntElementsAttr>(getValue())) {
     std::optional<ConstantIntRanges> result;
-    for (APInt &&val : constAttr) {
+    for (const APInt &val : arrayCstAttr) {
       auto range = ConstantIntRanges::constant(val);
-      if (!result) {
-        result = range;
-      } else {
-        result = result->rangeUnion(range);
-      }
+      result = (result ? result->rangeUnion(range) : range);
     }
 
-    if (result)
-      setResultRange(getResult(), *result);
-
+    assert(result && "Zero-sized vectors are not allowed");
+    setResultRange(getResult(), *result);
     return;
   }
 }

mlir/test/Dialect/Vector/int-range-interface.mlir

@@ -17,7 +17,6 @@ func.func @constant_splat() -> vector<8xi32> {
   func.return %1 : vector<8xi32>
 }
 
-
 // CHECK-LABEL: func @vector_splat
 // CHECK: test.reflect_bounds {smax = 5 : index, smin = 4 : index, umax = 5 : index, umin = 4 : index}
 func.func @vector_splat() -> vector<4xindex> {