Skip to content

Commit f98e552

Browse files
committed
[MLIR] Apply clang-tidy fixes for misc-use-internal-linkage in LLVMDialect.cpp (NFC)
1 parent 4c5877d commit f98e552

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -868,8 +868,9 @@ static bool isTypeCompatibleWithAtomicOp(Type type,
868868

869869
/// Verifies the attributes and the type of atomic memory access operations.
870870
template <typename OpTy>
871-
LogicalResult verifyAtomicMemOp(OpTy memOp, Type valueType,
872-
ArrayRef<AtomicOrdering> unsupportedOrderings) {
871+
static LogicalResult
872+
verifyAtomicMemOp(OpTy memOp, Type valueType,
873+
ArrayRef<AtomicOrdering> unsupportedOrderings) {
873874
if (memOp.getOrdering() != AtomicOrdering::not_atomic) {
874875
DataLayout dataLayout = DataLayout::closest(memOp);
875876
if (!isTypeCompatibleWithAtomicOp(valueType, dataLayout))
@@ -1119,7 +1120,7 @@ static LogicalResult verifyCallOpDebugInfo(CallOp callOp, LLVMFuncOp callee) {
11191120
/// Verify that the parameter and return types of the variadic callee type match
11201121
/// the `callOp` argument and result types.
11211122
template <typename OpTy>
1122-
LogicalResult verifyCallOpVarCalleeType(OpTy callOp) {
1123+
static LogicalResult verifyCallOpVarCalleeType(OpTy callOp) {
11231124
std::optional<LLVMFunctionType> varCalleeType = callOp.getVarCalleeType();
11241125
if (!varCalleeType)
11251126
return success();
@@ -2532,7 +2533,7 @@ LogicalResult GlobalOp::verifyRegions() {
25322533
// LLVM::GlobalCtorsOp
25332534
//===----------------------------------------------------------------------===//
25342535

2535-
LogicalResult checkGlobalXtorData(Operation *op, ArrayAttr data) {
2536+
static LogicalResult checkGlobalXtorData(Operation *op, ArrayAttr data) {
25362537
if (data.empty())
25372538
return success();
25382539

0 commit comments

Comments
 (0)