Skip to content

Commit f99b859

Browse files
committed
Feedback: remove redundant check
1 parent ba27cd9 commit f99b859

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

llvm/lib/Target/AMDGPU/AMDGPUMCResourceInfo.cpp

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -162,13 +162,10 @@ void MCResourceInfo::assignResourceInfoExpr(
162162

163163
SmallPtrSet<const MCExpr *, 8> Visited;
164164
MCSymbol *CalleeValSym = getSymbol(Callee->getName(), RIK, OutContext);
165-
bool CalleeIsVar = CalleeValSym->isVariable();
166165

167-
if (!CalleeIsVar ||
168-
(CalleeIsVar &&
169-
!findSymbolInExpr(Sym,
170-
CalleeValSym->getVariableValue(/*IsUsed=*/false),
171-
Visited))) {
166+
if (!CalleeValSym->isVariable() ||
167+
!findSymbolInExpr(
168+
Sym, CalleeValSym->getVariableValue(/*IsUsed=*/false), Visited)) {
172169
ArgExprs.push_back(MCSymbolRefExpr::create(CalleeValSym, OutContext));
173170
}
174171
}
@@ -229,13 +226,11 @@ void MCResourceInfo::gatherResourceInfo(
229226
SmallPtrSet<const MCExpr *, 8> Visited;
230227
MCSymbol *CalleeValSym =
231228
getSymbol(Callee->getName(), RIK_PrivateSegSize, OutContext);
232-
bool CalleeIsVar = CalleeValSym->isVariable();
233229

234-
if (!CalleeIsVar ||
235-
(CalleeIsVar &&
236-
!findSymbolInExpr(Sym,
237-
CalleeValSym->getVariableValue(/*IsUsed=*/false),
238-
Visited))) {
230+
if (!CalleeValSym->isVariable() ||
231+
!findSymbolInExpr(Sym,
232+
CalleeValSym->getVariableValue(/*IsUsed=*/false),
233+
Visited)) {
239234
ArgExprs.push_back(MCSymbolRefExpr::create(CalleeValSym, OutContext));
240235
}
241236
}

0 commit comments

Comments
 (0)