Skip to content

Commit f9ea4f3

Browse files
s-perronKeenuts
andauthored
Apply suggestions from code review
Co-authored-by: Nathan Gauër <[email protected]>
1 parent 954a86f commit f9ea4f3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

clang/include/clang/Basic/AttrDocs.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8255,7 +8255,7 @@ and https://microsoft.github.io/hlsl-specs/proposals/0013-wave-size-range.html
82558255
def VkConstantIdDocs : Documentation {
82568256
let Category = DocCatFunction;
82578257
let Content = [{
8258-
The ``vk::constant_id`` attribute specify the id for a SPIR-V specialization
8258+
The ``vk::constant_id`` attribute specifies the id for a SPIR-V specialization
82598259
constant. The attribute applies to const global scalar variables. The variable must be initialized with a C++11 constexpr.
82608260
In SPIR-V, the
82618261
variable will be replaced with an `OpSpecConstant` with the given id.

clang/include/clang/Basic/DiagnosticSemaKinds.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12921,7 +12921,7 @@ def err_spirv_enum_not_valid : Error<
1292112921

1292212922
def err_specialization_const_lit_init
1292312923
: Error<"variable with 'vk::constant_id' attribute cannot have an "
12924-
"initializer that is not a constexpr">;
12924+
"initializer that is not a literal">;
1292512925
def err_specialization_const_missing_initializer
1292612926
: Error<
1292712927
"variable with 'vk::constant_id' attribute must have an initializer">;

0 commit comments

Comments
 (0)