Add TODO

boomanaiden154 · boomanaiden154 · commit fa510f278480 · 2025-11-03T18:54:07.000Z
diff --git a/libcxx/include/string b/libcxx/include/string
@@ -1212,6 +1212,9 @@ public:
   }
 #  endif // _LIBCPP_CXX03_LANG
 
+  // TODO(boomanaiden154): Once we mark this in destructors as dead on return,
+  // we can use a normal call to __reset_internal_buffer and remove the extra
+  // __rep constructor.
   inline _LIBCPP_CONSTEXPR_SINCE_CXX20 ~basic_string() { __reset_internal_buffer(__rep(__uninitialized_tag())); }
 
   _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 operator __self_view() const _NOEXCEPT {

Original file line number	Diff line number	Diff line change
`@@ -1212,6 +1212,9 @@ public:`
`1212`	`1212`	`}`
`1213`	`1213`	`# endif // _LIBCPP_CXX03_LANG`
`1214`	`1214`
	`1215`	`+ // TODO(boomanaiden154): Once we mark this in destructors as dead on return,`
	`1216`	`+ // we can use a normal call to __reset_internal_buffer and remove the extra`
	`1217`	`+ // __rep constructor.`
`1215`	`1218`	`inline _LIBCPP_CONSTEXPR_SINCE_CXX20 ~basic_string() { __reset_internal_buffer(__rep(__uninitialized_tag())); }`
`1216`	`1219`
`1217`	`1220`	`_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 operator __self_view() const _NOEXCEPT {`