clean up

joaosaffran · joaosaffran · commit fa60959c0c1d · 2025-08-29T18:19:42.000-07:00
diff --git a/clang/lib/Sema/SemaHLSL.cpp b/clang/lib/Sema/SemaHLSL.cpp
@@ -1252,7 +1252,6 @@ bool SemaHLSL::handleRootSignatureElements(
     case llvm::dxil::ResourceClass::Sampler:
       return llvm::dxbc::DescriptorRangeType::Sampler;
     }
-
     llvm_unreachable("Unhandled Resource Class");
   };
 
@@ -1297,6 +1296,7 @@ bool SemaHLSL::handleRootSignatureElements(
         // value
         ReportError(Loc, 1, 0xfffffffe);
       }
+
       if (!llvm::hlsl::rootsig::verifyDescriptorRangeFlag(
               Version, toDescriptorRangeType(Clause->Type), Clause->Flags))
         ReportFlagError(Loc);
diff --git a/llvm/lib/Frontend/HLSL/RootSignatureValidations.cpp b/llvm/lib/Frontend/HLSL/RootSignatureValidations.cpp
@@ -122,9 +122,6 @@ bool verifyDescriptorRangeFlag(uint32_t Version, dxbc::DescriptorRangeType Type,
   }
   return (Flags & ~Mask) == FlagT::None;
 }
-
-// This is included to avoid including BinaryFormat/DXContainer to make the
-// flags conversion, since this might cause compilation times to increase.
 bool verifyDescriptorRangeFlag(uint32_t Version, dxbc::DescriptorRangeType Type,
                                uint32_t Flags) {
   return verifyDescriptorRangeFlag(Version, Type,

Original file line number	Diff line number	Diff line change
`@@ -1252,7 +1252,6 @@ bool SemaHLSL::handleRootSignatureElements(`
`1252`	`1252`	`case llvm::dxil::ResourceClass::Sampler:`
`1253`	`1253`	`return llvm::dxbc::DescriptorRangeType::Sampler;`
`1254`	`1254`	`}`
`1255`		`-`
`1256`	`1255`	`llvm_unreachable("Unhandled Resource Class");`
`1257`	`1256`	`};`
`1258`	`1257`
`@@ -1297,6 +1296,7 @@ bool SemaHLSL::handleRootSignatureElements(`
`1297`	`1296`	`// value`
`1298`	`1297`	`ReportError(Loc, 1, 0xfffffffe);`
`1299`	`1298`	`}`
	`1299`	`+`
`1300`	`1300`	`if (!llvm::hlsl::rootsig::verifyDescriptorRangeFlag(`
`1301`	`1301`	`Version, toDescriptorRangeType(Clause->Type), Clause->Flags))`
`1302`	`1302`	`ReportFlagError(Loc);`
Original file line number	Diff line number	Diff line change
`@@ -122,9 +122,6 @@ bool verifyDescriptorRangeFlag(uint32_t Version, dxbc::DescriptorRangeType Type,`
`122`	`122`	`}`
`123`	`123`	`return (Flags & ~Mask) == FlagT::None;`
`124`	`124`	`}`
`125`		`-`
`126`		`-// This is included to avoid including BinaryFormat/DXContainer to make the`
`127`		`-// flags conversion, since this might cause compilation times to increase.`
`128`	`125`	`bool verifyDescriptorRangeFlag(uint32_t Version, dxbc::DescriptorRangeType Type,`
`129`	`126`	`uint32_t Flags) {`
`130`	`127`	`return verifyDescriptorRangeFlag(Version, Type,`