Commit fac05cf
committed
[Dexter] Use continue when resuming lldb execution to reach breakpoint
Currently, Dexter's interface for lldb and lldb-dap has a post-step hook
that checks to see whether lldb reports that we stopped because we
completed a step, and if so checks to see whether the current $pc address
also matches a known breakpoint whose conditions (if any) are met, and if
so it requests to "step in", so that we "resume" execution, stopping again
at the current address, such that lldb now reports that we have hit a
breakpoint and provides the list of breakpoints that were hit.
This logic has a flaw however: the call to "step in" sets an implicit
breakpoint on the next line. In Dexter's default stepping mode this is not
an issue, as we intend to step there eventually. When we use DexContinue,
however, we set a breakpoint from which we wish to continue to the next
user-specified breakpoint, rather than stepping. Currently, there is a bug
where Dexter sets a DexContinue breakpoint, arrives at that bp from a step,
requests "step in" so that LLDB gives us the hit breakpoint ID, requests
"continue" to hit the next user breakpoint, and then arrives at the next
line after the continue due to the earlier "step in" request. This
effectively negates the DexContinue command.
This patch fixes this behaviour by using "continue" instead of "step in" in
the post-step hook, ensuring that no implicit breakpoint is set so that we
do not incorrectly stop at the next line.1 parent 9a1e478 commit fac05cf
File tree
1 file changed
+2
-2
lines changed- cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb
1 file changed
+2
-2
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
235 | | - | |
| 235 | + | |
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
| |||
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
444 | | - | |
| 444 | + | |
445 | 445 | | |
446 | 446 | | |
447 | 447 | | |
| |||
0 commit comments