Skip to content

Commit fadfd03

Browse files
committed
[NFC] Fixed a couple issues found trhough static analysis tool.
1 parent 4eaeba8 commit fadfd03

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

clang-tools-extra/clangd/ModulesBuilder.cpp

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,13 @@ class ReusablePrerequisiteModules : public PrerequisiteModules {
142142
public:
143143
ReusablePrerequisiteModules() = default;
144144

145-
ReusablePrerequisiteModules(const ReusablePrerequisiteModules &Other) =
146-
default;
147-
ReusablePrerequisiteModules &
148-
operator=(const ReusablePrerequisiteModules &) = default;
145+
ReusablePrerequisiteModules(const ReusablePrerequisiteModules &Other)
146+
: PrerequisiteModules(Other) {
147+
RequiredModules = Other.RequiredModules;
148+
BuiltModuleNames = Other.BuiltModuleNames;
149+
}
150+
151+
ReusablePrerequisiteModules &operator=(const ReusablePrerequisiteModules &) = delete;
149152
ReusablePrerequisiteModules(ReusablePrerequisiteModules &&) = delete;
150153
ReusablePrerequisiteModules
151154
operator=(ReusablePrerequisiteModules &&) = delete;
@@ -310,7 +313,7 @@ bool ReusablePrerequisiteModules::canReuse(
310313
llvm::SmallVector<llvm::StringRef> BMIPaths;
311314
for (auto &MF : RequiredModules)
312315
BMIPaths.push_back(MF->getModuleFilePath());
313-
return IsModuleFilesUpToDate(BMIPaths, *this, VFS);
316+
return IsModuleFilesUpToDate(std::move(BMIPaths), *this, VFS);
314317
}
315318

316319
class ModuleFileCache {

0 commit comments

Comments
 (0)