Actually, zero dimensions are allowed

Author: krzysz00

mlir/lib/Dialect/MemRef/IR/ValueBoundsOpInterfaceImpl.cpp

@@ -51,7 +51,7 @@ struct DimOpInterface
     auto dimOp = cast<DimOp>(op);
     assert(value == dimOp.getResult() && "invalid value");
 
-    cstr.bound(value) > 0;
+    cstr.bound(value) >= 0;
     auto constIndex = dimOp.getConstantIndex();
     if (!constIndex.has_value())
       return;

mlir/lib/Dialect/Tensor/IR/ValueBoundsOpInterfaceImpl.cpp

@@ -38,7 +38,7 @@ struct DimOpInterface
     auto dimOp = cast<DimOp>(op);
     assert(value == dimOp.getResult() && "invalid value");
 
-    cstr.bound(value) > 0;
+    cstr.bound(value) >= 0;
     auto constIndex = dimOp.getConstantIndex();
     if (!constIndex.has_value())
       return;

mlir/test/Dialect/MemRef/value-bounds-op-interface-impl.mlir

@@ -57,7 +57,7 @@ func.func @memref_dim_all_positive(%m: memref<?xf32>, %x: index) {
   %c0 = arith.constant 0 : index
   %0 = memref.dim %m, %x : memref<?xf32>
   // expected-remark @below{{true}}
-  "test.compare"(%0, %c0) {cmp = "GT"} : (index, index) -> ()
+  "test.compare"(%0, %c0) {cmp = "GE"} : (index, index) -> ()
   return
 }
 

mlir/test/Dialect/Tensor/value-bounds-op-interface-impl.mlir

@@ -49,7 +49,7 @@ func.func @dim_all_positive(%t: tensor<?xf32>, %x: index) {
   %c0 = arith.constant 0 : index
   %0 = tensor.dim %t, %x : tensor<?xf32>
   // expected-remark @below{{true}}
-  "test.compare"(%0, %c0) {cmp = "GT" } : (index, index) -> ()
+  "test.compare"(%0, %c0) {cmp = "GE" } : (index, index) -> ()
   return
 }