Apply my own review feedback

Author: cor3ntin

clang/include/clang/Sema/Sema.h

@@ -10659,10 +10659,10 @@ class Sema final : public SemaBase {
                            SourceLocation EndLoc);
   void ActOnForEachDeclStmt(DeclGroupPtrTy Decl);
 
-  /// DiagnoseDiscardedNodiscard - Given an expression that is semantically
+  /// DiagnoseDiscardedExprMarkedNodiscard - Given an expression that is semantically
   /// a discarded-value expression, diagnose if any [[nodiscard]] value
   /// has been discarded
-  void DiagnoseDiscardedNodiscard(const Expr *E);
+  void DiagnoseDiscardedExprMarkedNodiscard(const Expr *E);
 
   /// DiagnoseUnusedExprResult - If the statement passed in is an expression
   /// whose result is unused, warn.

clang/lib/Sema/SemaExprMember.cpp

@@ -1133,7 +1133,7 @@ Sema::BuildMemberReferenceExpr(Expr *BaseExpr, QualType BaseExprType,
     if (Converted.isInvalid())
       return true;
     BaseExpr = Converted.get();
-    DiagnoseDiscardedNodiscard(BaseExpr);
+    DiagnoseDiscardedExprMarkedNodiscard(BaseExpr);
     return false;
   };
   auto MakeGLValue = [&] {

clang/lib/Sema/SemaStmt.cpp

@@ -227,6 +227,11 @@ static bool DiagnoseNoDiscard(Sema &S, const NamedDecl *OffendingDecl,
 }
 
 namespace {
+
+// Diagnoses unused expressions that call functions marked [[nodiscard]],
+// [[gnu::warn_unused_result]] and similar.
+// Additionally, a DiagID can be provided to emit a warning in additional contexts
+// (such as for an unused LHS of a comma expression)
 void DiagnoseUnused(Sema &S, const Expr *E, std::optional<unsigned> DiagID) {
   bool NoDiscardOnly = !DiagID.has_value();
 
@@ -412,7 +417,7 @@ void DiagnoseUnused(Sema &S, const Expr *E, std::optional<unsigned> DiagID) {
 }
 } // namespace
 
-void Sema::DiagnoseDiscardedNodiscard(const Expr *E) {
+void Sema::DiagnoseDiscardedExprMarkedNodiscard(const Expr *E) {
   DiagnoseUnused(*this, E, std::nullopt);
 }