Apply Matt's comments

Author: Yuanke Luo

llvm/test/CodeGen/X86/early-clobber.mir

@@ -4,43 +4,11 @@
 # Test register live range that is split from rematerializing. The live range should
 # start with Slot_EarlyClobber instead of Slot_Register. Machineverifer can check it.
 
---- |
-  @g = external constant [2 x i32], align 4
-
-  ; Function Attrs: nounwind
-  define i32 @test(i32 noundef %a) #0 {
-  entry:
-    %0 = xor i32 %a, %a
-    tail call void asm sideeffect "", "~{ebp},~{eax},~{ebx},~{ecx},~{edx},~{esi},~{edi},~{dirflag},~{fpsr},~{flags}"()
-    br i1 undef, label %if, label %else
-
-  if:                                               ; preds = %entry
-    %add = add i32 %0, 1
-    br label %exit
-
-  else:                                             ; preds = %entry
-    %shl = shl i32 %0, 1
-    br label %exit
-
-  exit:                                             ; preds = %else, %if
-    %phi = phi i32 [ %add, %if ], [ %shl, %else ]
-    ret i32 %phi
-  }
-
-  attributes #0 = { nounwind }
-
 ...
 ---
 name:            test
 alignment:       16
 tracksRegLiveness: true
-registers:
-  - { id: 0, class: gr32_abcd }
-  - { id: 1, class: gr32 }
-  - { id: 2, class: gr32 }
-  - { id: 3, class: gr32 }
-  - { id: 4, class: gr8 }
-  - { id: 5, class: gr32 }
 frameInfo:
   maxAlignment:    4
 fixedStack:
@@ -53,28 +21,42 @@ body:             |
   ; CHECK-NEXT:   liveins: $ebp, $ebx, $edi, $esi
   ; CHECK-NEXT: {{  $}}
   ; CHECK-NEXT:   frame-setup PUSH32r killed $ebp, implicit-def $esp, implicit $esp
+  ; CHECK-NEXT:   frame-setup CFI_INSTRUCTION def_cfa_offset 8
   ; CHECK-NEXT:   frame-setup PUSH32r killed $ebx, implicit-def $esp, implicit $esp
+  ; CHECK-NEXT:   frame-setup CFI_INSTRUCTION def_cfa_offset 12
   ; CHECK-NEXT:   frame-setup PUSH32r killed $edi, implicit-def $esp, implicit $esp
+  ; CHECK-NEXT:   frame-setup CFI_INSTRUCTION def_cfa_offset 16
   ; CHECK-NEXT:   frame-setup PUSH32r killed $esi, implicit-def $esp, implicit $esp
+  ; CHECK-NEXT:   frame-setup CFI_INSTRUCTION def_cfa_offset 20
   ; CHECK-NEXT:   $esp = frame-setup SUB32ri $esp, 12, implicit-def dead $eflags
+  ; CHECK-NEXT:   frame-setup CFI_INSTRUCTION def_cfa_offset 32
+  ; CHECK-NEXT:   CFI_INSTRUCTION offset $esi, -20
+  ; CHECK-NEXT:   CFI_INSTRUCTION offset $edi, -16
+  ; CHECK-NEXT:   CFI_INSTRUCTION offset $ebx, -12
+  ; CHECK-NEXT:   CFI_INSTRUCTION offset $ebp, -8
   ; CHECK-NEXT:   INLINEASM &"", 1 /* sideeffect attdialect */, 12 /* clobber */, implicit-def dead early-clobber $ebp, 12 /* clobber */, implicit-def dead early-clobber $eax, 12 /* clobber */, implicit-def dead early-clobber $ebx, 12 /* clobber */, implicit-def dead early-clobber $ecx, 12 /* clobber */, implicit-def dead early-clobber $edx, 12 /* clobber */, implicit-def dead early-clobber $esi, 12 /* clobber */, implicit-def dead early-clobber $edi, 12 /* clobber */, implicit-def dead early-clobber $df, 12 /* clobber */, implicit-def early-clobber $fpsw, 12 /* clobber */, implicit-def dead early-clobber $eflags
   ; CHECK-NEXT:   early-clobber renamable $eax = XOR32rr undef $eax, undef $eax, implicit-def dead $eflags
   ; CHECK-NEXT:   TEST8rr renamable $al, renamable $al, implicit-def $eflags
   ; CHECK-NEXT:   JCC_1 %bb.2, 5, implicit $eflags
   ; CHECK-NEXT: {{  $}}
-  ; CHECK-NEXT: bb.1.if:
+  ; CHECK-NEXT: bb.1:
   ; CHECK-NEXT:   successors: %bb.2(0x80000000)
   ; CHECK-NEXT: {{  $}}
   ; CHECK-NEXT:   renamable $eax = MOV32ri 1
   ; CHECK-NEXT: {{  $}}
-  ; CHECK-NEXT: bb.2.exit:
+  ; CHECK-NEXT: bb.2:
   ; CHECK-NEXT:   liveins: $eax
   ; CHECK-NEXT: {{  $}}
   ; CHECK-NEXT:   $esp = frame-destroy ADD32ri $esp, 12, implicit-def dead $eflags
+  ; CHECK-NEXT:   frame-destroy CFI_INSTRUCTION def_cfa_offset 20
   ; CHECK-NEXT:   $esi = frame-destroy POP32r implicit-def $esp, implicit $esp
+  ; CHECK-NEXT:   frame-destroy CFI_INSTRUCTION def_cfa_offset 16
   ; CHECK-NEXT:   $edi = frame-destroy POP32r implicit-def $esp, implicit $esp
+  ; CHECK-NEXT:   frame-destroy CFI_INSTRUCTION def_cfa_offset 12
   ; CHECK-NEXT:   $ebx = frame-destroy POP32r implicit-def $esp, implicit $esp
+  ; CHECK-NEXT:   frame-destroy CFI_INSTRUCTION def_cfa_offset 8
   ; CHECK-NEXT:   $ebp = frame-destroy POP32r implicit-def $esp, implicit $esp
+  ; CHECK-NEXT:   frame-destroy CFI_INSTRUCTION def_cfa_offset 4
   ; CHECK-NEXT:   RET 0, $eax
   bb.0.entry:
     successors: %bb.1, %bb.2
@@ -86,15 +68,15 @@ body:             |
     JCC_1 %bb.2, 5, implicit killed $eflags
     JMP_1 %bb.1
 
-  bb.1.if:
+  bb.1:
     %1:gr32 = MOV32ri 1
     %5:gr32 = COPY killed %1
     JMP_1 %bb.3
 
-  bb.2.else:
+  bb.2:
     %5:gr32 = COPY killed %0
 
-  bb.3.exit:
+  bb.3:
     %3:gr32 = COPY killed %5
     $eax = COPY killed %3
     RET 0, killed $eax