Use firstInOverlay instead of lastInOverlay

Author: mysterymath

lld/ELF/LinkerScript.cpp

@@ -1229,6 +1229,8 @@ bool LinkerScript::assignOffsets(OutputSection *sec) {
   // We can call this method multiple times during the creation of
   // thunks and want to start over calculation each time.
   sec->size = 0;
+  if (sec->firstInOverlay)
+    state->overlaySize = 0;
 
   // We visited SectionsCommands from processSectionCommands to
   // layout sections. Now, we visit SectionsCommands again to fix
@@ -1284,8 +1286,6 @@ bool LinkerScript::assignOffsets(OutputSection *sec) {
     // NOBITS TLS sections are similar. Additionally save the end address.
     state->tbssAddr = dot;
     dot = savedDot;
-  } else if (sec->lastInOverlay) {
-    state->overlaySize = 0;
   }
   return addressChanged;
 }

lld/ELF/LinkerScript.h

@@ -311,7 +311,7 @@ class LinkerScript final {
     MemoryRegion *lmaRegion = nullptr;
     uint64_t lmaOffset = 0;
     uint64_t tbssAddr = 0;
-    uint64_t overlaySize = 0;
+    uint64_t overlaySize;
   };
 
   Ctx &ctx;

lld/ELF/OutputSections.h

@@ -102,7 +102,7 @@ class OutputSection final : public SectionBase {
   bool expressionsUseSymbols = false;
   bool usedInExpression = false;
   bool inOverlay = false;
-  bool lastInOverlay = false;
+  bool firstInOverlay = false;
 
   // Tracks whether the section has ever had an input section added to it, even
   // if the section was later removed (e.g. because it is a synthetic section

lld/ELF/ScriptParser.cpp

@@ -588,7 +588,7 @@ SmallVector<SectionCommand *, 0> ScriptParser::readOverlay() {
     prev = &osd->osec;
   }
   if (!v.empty())
-    static_cast<OutputDesc *>(v.back())->osec.lastInOverlay = true;
+    static_cast<OutputDesc *>(v.front())->osec.firstInOverlay = true;
   if (consume(">")) {
     StringRef regionName = readName();
     for (SectionCommand *od : v)