Skip to content

Commit fcc66bd

Browse files
Addressed review feedback:
1. Removed whitespace from top of llvm/test/DebugInfo/X86/selectionDAG-load-sext.mir 2. Added a sentence to explain why llvm/test/DebugInfo/X86/selectionDAG-load-sext.mir exists 3. Removed #include "llvm/BinaryFormat/Dwarf.h" from top of DAGCombiner.cpp
1 parent e18ad47 commit fcc66bd

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
#include "llvm/Analysis/TargetLibraryInfo.h"
3333
#include "llvm/Analysis/ValueTracking.h"
3434
#include "llvm/Analysis/VectorUtils.h"
35-
#include "llvm/BinaryFormat/Dwarf.h"
3635
#include "llvm/CodeGen/ByteProvider.h"
3736
#include "llvm/CodeGen/DAGCombine.h"
3837
#include "llvm/CodeGen/ISDOpcodes.h"

llvm/test/DebugInfo/X86/selectionDAG-load-sext.mir

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# This test checks that after SelectionDAG runs, it preserves the debug info that is lost due to the DAGCombiner combining a load and a sext instruction, where the #dbg_value is pointing to the result of the load.
12

23
# RUN: llc -O2 %s -mtriple=x86_64-unkown-linux -start-before=x86-isel -stop-after=x86-isel -o - | FileCheck %s --check-prefix=MIR
34
# RUN: llc -O2 %s -start-before=x86-isel -mtriple=x86_64-unkown-linux --filetype=obj -o %t.o
@@ -7,7 +8,7 @@
78
# MIR-LABEL: bb.0
89
# MIR: %{{[0-9a-zA-Z]+}}{{.*}} = MOVSX64rm32 ${{.*}}, 1, $noreg, @GlobArr, $noreg, debug-instr-number [[INSTR_NUM:[0-9]+]]
910
# MIR-NEXT: DBG_INSTR_REF ![[IDX]], !DIExpression(DW_OP_LLVM_arg, 0), dbg-instr-ref([[INSTR_NUM]], 0)
10-
# MIR-NEXT DBG_INSTR_REF ![[IDX]], !DIExpression(DW_OP_LLVM_arg, 0, DW_OP_LLVM_fragment, 0, 32), dbg-instr-ref([[INSTR_NUM]], 0)
11+
# MIR-NEXT: DBG_INSTR_REF ![[IDX]], !DIExpression(DW_OP_LLVM_arg, 0, DW_OP_LLVM_fragment, 0, 32), dbg-instr-ref([[INSTR_NUM]], 0)
1112

1213
# DUMP: DW_AT_location (indexed ({{[0-9]+}}x{{[0-9]+}}) loclist = 0x{{[0-9]+}}:
1314
# DUMP-NEXT: [0x{{[0-9]+}}, 0x{{[0-9]+}}): {{.*}}, DW_OP_piece 0x4

0 commit comments

Comments
 (0)