Remove all the Expr Constant AST visitors. run clan format

Author: farzonl

clang/include/clang/AST/Expr.h

@@ -309,7 +309,7 @@ class Expr : public ValueStmt {
     MLV_DuplicateVectorComponents,
     MLV_DuplicateMatrixComponents,
     MLV_InvalidExpression,
-    MLV_LValueCast,           // Specialized form of MLV_InvalidExpression.
+    MLV_LValueCast, // Specialized form of MLV_InvalidExpression.
     MLV_IncompleteType,
     MLV_ConstQualified,
     MLV_ConstQualifiedField,
@@ -342,17 +342,17 @@ class Expr : public ValueStmt {
     enum Kinds {
       CL_LValue,
       CL_XValue,
-      CL_Function, // Functions cannot be lvalues in C.
-      CL_Void, // Void cannot be an lvalue in C.
+      CL_Function,        // Functions cannot be lvalues in C.
+      CL_Void,            // Void cannot be an lvalue in C.
       CL_AddressableVoid, // Void expression whose address can be taken in C.
       CL_DuplicateVectorComponents, // A vector shuffle with dupes.
       CL_DuplicateMatrixComponents, // A matrix shuffle with dupes.
       CL_MemberFunction, // An expression referring to a member function
       CL_SubObjCPropertySetting,
-      CL_ClassTemporary, // A temporary of class type, or subobject thereof.
-      CL_ArrayTemporary, // A temporary of array type.
+      CL_ClassTemporary,    // A temporary of class type, or subobject thereof.
+      CL_ArrayTemporary,    // A temporary of array type.
       CL_ObjCMessageRValue, // ObjC message is an rvalue
-      CL_PRValue // A prvalue for any other reason, of any other type
+      CL_PRValue            // A prvalue for any other reason, of any other type
     };
     /// The results of modification testing.
     enum ModifiableType {
@@ -6524,11 +6524,6 @@ template <class Derived> class ElementAccessExprBase : public Expr {
   }
   SourceLocation getEndLoc() const LLVM_READONLY { return AccessorLoc; }
 
-  /*static bool classof(const Stmt *T) {
-    return T->getStmtClass() == ExtVectorElementExprClass ||
-           T->getStmtClass() == MatrixElementExprClass;
-  }*/
-
   child_range children() { return child_range(&Base, &Base + 1); }
   const_child_range children() const {
     return const_child_range(&Base, &Base + 1);

clang/lib/AST/ByteCode/Compiler.cpp

@@ -4090,12 +4090,6 @@ bool Compiler<Emitter>::VisitShuffleVectorExpr(const ShuffleVectorExpr *E) {
   return true;
 }
 
-template <class Emitter>
-bool Compiler<Emitter>::VisitMatrixElementExpr(const MatrixElementExpr *Node) {
-  // TODO
-  return false;
-}
-
 template <class Emitter>
 bool Compiler<Emitter>::VisitExtVectorElementExpr(
     const ExtVectorElementExpr *E) {

clang/lib/AST/ByteCode/Compiler.h

@@ -223,7 +223,6 @@ class Compiler : public ConstStmtVisitor<Compiler<Emitter>, bool>,
   bool VisitConvertVectorExpr(const ConvertVectorExpr *E);
   bool VisitShuffleVectorExpr(const ShuffleVectorExpr *E);
   bool VisitExtVectorElementExpr(const ExtVectorElementExpr *E);
-  bool VisitMatrixElementExpr(const MatrixElementExpr *E);
   bool VisitObjCBoxedExpr(const ObjCBoxedExpr *E);
   bool VisitCXXStdInitializerListExpr(const CXXStdInitializerListExpr *E);
   bool VisitStmtExpr(const StmtExpr *E);

clang/lib/AST/ExprConstant.cpp

@@ -8993,8 +8993,6 @@ class ExprEvaluatorBase
            DerivedSuccess(Result, E);
   }
 
-  bool VisitMatrixElementExpr(const MatrixElementExpr *E) { return false; }
-
   bool VisitExtVectorElementExpr(const ExtVectorElementExpr *E) {
     APValue Val;
     if (!Evaluate(Val, Info, E->getBase()))
@@ -9337,7 +9335,6 @@ class LValueExprEvaluator
   bool VisitCXXUuidofExpr(const CXXUuidofExpr *E);
   bool VisitArraySubscriptExpr(const ArraySubscriptExpr *E);
   bool VisitExtVectorElementExpr(const ExtVectorElementExpr *E);
-  bool VisitMatrixElementExpr(const MatrixElementExpr *E);
   bool VisitUnaryDeref(const UnaryOperator *E);
   bool VisitUnaryReal(const UnaryOperator *E);
   bool VisitUnaryImag(const UnaryOperator *E);
@@ -9699,10 +9696,6 @@ bool LValueExprEvaluator::VisitMemberExpr(const MemberExpr *E) {
   return LValueExprEvaluatorBaseTy::VisitMemberExpr(E);
 }
 
-bool LValueExprEvaluator::VisitMatrixElementExpr(const MatrixElementExpr *E) {
-  return false;
-}
-
 bool LValueExprEvaluator::VisitExtVectorElementExpr(
     const ExtVectorElementExpr *E) {
   bool Success = true;

clang/lib/CIR/CodeGen/CIRGenExpr.cpp

@@ -1202,6 +1202,11 @@ CIRGenFunction::emitArraySubscriptExpr(const clang::ArraySubscriptExpr *e) {
   return lv;
 }
 
+LValue CIRGenFunction::emitMatrixElementExpr(const MatrixElementExpr *e) {
+  // FIXME: support "matrix swizzle" if/when CIR needs it. llvm#171477
+  return emitUnsupportedLValue(E, "Matrix swizzle");
+}
+
 LValue CIRGenFunction::emitExtVectorElementExpr(const ExtVectorElementExpr *e) {
   // Emit the base vector as an l-value.
   LValue base;

clang/lib/CIR/CodeGen/CIRGenFunction.h

@@ -1333,7 +1333,7 @@ class CIRGenFunction : public CIRGenTypeCache {
 
   LValue emitExtVectorElementExpr(const ExtVectorElementExpr *e);
 
-  LValue emitMatrixElementExpr(cost MatrixElementExpr *e);
+  LValue emitMatrixElementExpr(const MatrixElementExpr *e);
 
   Address emitArrayToPointerDecay(const Expr *e,
                                   LValueBaseInfo *baseInfo = nullptr);

clang/test/AST/HLSL/pch_with_matrix_element_accessor.hlsl

@@ -23,4 +23,4 @@ float4 getDiag() {
 // CHECK-NEXT: DeclRefExpr {{.*}} 'float4':'vector<float, 4>' lvalue ParmVar {{.*}} 'V' 'float4':'vector<float, 4>'
 void setRowZero(float4 V) {  
   gM._m00_m01_m02_m03 = V;
-}
+}