oops, silly bug

Author: Moxinilian

mlir/lib/Dialect/IRDL/IR/IRDL.cpp

@@ -107,7 +107,7 @@ LogicalResult OperationOp::verifyRegions() {
   // Verify that no two operand, result or region share the same name.
   for (size_t i : llvm::seq(valueNames.size())) {
     for (size_t j : llvm::seq(i + 1, valueNames.size())) {
-      auto &[lhs, lhsSet] = valueNames[i];
+      auto [lhs, lhsSet] = valueNames[i];
       auto &[rhs, rhsSet] = valueNames[j];
       llvm::set_intersect(lhsSet, rhsSet);
       if (!lhsSet.empty())

mlir/test/Dialect/IRDL/invalid.irdl.mlir

@@ -117,6 +117,19 @@ irdl.dialect @testd {
 
 // -----
 
+irdl.dialect @testd {
+  // expected-error@+1 {{contains a value named 'baz' for both its regions and results}}
+  irdl.operation @op {
+    %0 = irdl.any
+    %1 = irdl.region
+    irdl.regions(baz: %1)
+    irdl.operands(qux: %0)
+    irdl.results(baz: %0)
+  }
+}
+
+// -----
+
 irdl.dialect @testd {
   irdl.type @type {
     // expected-error@+1 {{symbol '@foo' not found}}