Skip to content

Commit fd4ef8e

Browse files
mahesh-attardemahesh-attarde
authored
[X86][GlobalIsel] Support G_INTRINSIC_TRUNC/G_FCEIL/G_FFLOOR (#156633)
This PR adds support for C/CPP Lib Intrinsic G_INTRINSIC_TRUNC/G_FCEIL/G_FFLOOR from LangRef in GlobalIsel.
1 parent 757bb36 commit fd4ef8e

File tree

4 files changed

+135
-23
lines changed

4 files changed

+135
-23
lines changed

‎llvm/lib/Target/X86/GISel/X86LegalizerInfo.cpp‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,11 @@ X86LegalizerInfo::X86LegalizerInfo(const X86Subtarget &STI,
9898
.widenScalarToNextPow2(0, /*Min=*/8)
9999
.clampScalar(0, s8, sMaxScalar);
100100

101-
getActionDefinitionsBuilder(
102-
{G_LROUND, G_LLROUND, G_FCOS, G_FCOSH, G_FACOS, G_FSIN, G_FSINH,
103-
G_FASIN, G_FTAN, G_FTANH, G_FATAN, G_FATAN2, G_FPOW, G_FEXP,
104-
G_FEXP2, G_FEXP10, G_FLOG, G_FLOG2, G_FLOG10, G_FPOWI, G_FSINCOS})
101+
getActionDefinitionsBuilder({G_LROUND, G_LLROUND, G_FCOS, G_FCOSH, G_FACOS,
102+
G_FSIN, G_FSINH, G_FASIN, G_FTAN, G_FTANH,
103+
G_FATAN, G_FATAN2, G_FPOW, G_FEXP, G_FEXP2,
104+
G_FEXP10, G_FLOG, G_FLOG2, G_FLOG10, G_FPOWI,
105+
G_FSINCOS, G_FCEIL, G_FFLOOR})
105106
.libcall();
106107

107108
getActionDefinitionsBuilder(G_FSQRT)
@@ -580,7 +581,7 @@ X86LegalizerInfo::X86LegalizerInfo(const X86Subtarget &STI,
580581
.lower();
581582

582583
// fp intrinsics
583-
getActionDefinitionsBuilder(G_INTRINSIC_ROUNDEVEN)
584+
getActionDefinitionsBuilder({G_INTRINSIC_ROUNDEVEN, G_INTRINSIC_TRUNC})
584585
.scalarize(0)
585586
.minScalar(0, LLT::scalar(32))
586587
.libcall();

‎llvm/test/CodeGen/X86/isel-ceil.ll‎

Lines changed: 43 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
; RUN: llc < %s -mtriple=x86_64-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X64,FASTISEL-X64
44
; RUN: llc < %s -mtriple=i686-linux-gnu | FileCheck %s --check-prefixes=X86
55
; RUN: llc < %s -mtriple=i686-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X86
6-
; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=GISEL-X64
7-
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=X86
6+
; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=GISEL-X64
7+
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=GISEL-X86
88

99
define float @ceil_f32(float %a) nounwind readnone {
1010
; DAG-X64-LABEL: ceil_f32:
@@ -29,7 +29,19 @@ define float @ceil_f32(float %a) nounwind readnone {
2929
;
3030
; GISEL-X64-LABEL: ceil_f32:
3131
; GISEL-X64: # %bb.0:
32-
; GISEL-X64-NEXT: jmp ceilf@PLT # TAILCALL
32+
; GISEL-X64-NEXT: pushq %rax
33+
; GISEL-X64-NEXT: callq ceilf
34+
; GISEL-X64-NEXT: popq %rax
35+
; GISEL-X64-NEXT: retq
36+
;
37+
; GISEL-X86-LABEL: ceil_f32:
38+
; GISEL-X86: # %bb.0:
39+
; GISEL-X86-NEXT: subl $12, %esp
40+
; GISEL-X86-NEXT: movl {{[0-9]+}}(%esp), %eax
41+
; GISEL-X86-NEXT: movl %eax, (%esp)
42+
; GISEL-X86-NEXT: calll ceilf
43+
; GISEL-X86-NEXT: addl $12, %esp
44+
; GISEL-X86-NEXT: retl
3345
%c = call float @llvm.ceil.f32(float %a)
3446
ret float %c
3547
}
@@ -57,7 +69,24 @@ define double @ceil_f64(double %a) nounwind readnone {
5769
;
5870
; GISEL-X64-LABEL: ceil_f64:
5971
; GISEL-X64: # %bb.0:
60-
; GISEL-X64-NEXT: jmp ceil@PLT # TAILCALL
72+
; GISEL-X64-NEXT: pushq %rax
73+
; GISEL-X64-NEXT: callq ceil
74+
; GISEL-X64-NEXT: popq %rax
75+
; GISEL-X64-NEXT: retq
76+
;
77+
; GISEL-X86-LABEL: ceil_f64:
78+
; GISEL-X86: # %bb.0:
79+
; GISEL-X86-NEXT: subl $12, %esp
80+
; GISEL-X86-NEXT: leal {{[0-9]+}}(%esp), %eax
81+
; GISEL-X86-NEXT: movl {{[0-9]+}}(%esp), %ecx
82+
; GISEL-X86-NEXT: movl 4(%eax), %eax
83+
; GISEL-X86-NEXT: xorl %edx, %edx
84+
; GISEL-X86-NEXT: addl %esp, %edx
85+
; GISEL-X86-NEXT: movl %ecx, (%esp)
86+
; GISEL-X86-NEXT: movl %eax, 4(%edx)
87+
; GISEL-X86-NEXT: calll ceil
88+
; GISEL-X86-NEXT: addl $12, %esp
89+
; GISEL-X86-NEXT: retl
6190
%c = call double @llvm.ceil.f64(double %a)
6291
ret double %c
6392
}
@@ -86,10 +115,18 @@ define x86_fp80 @ceil_f80(x86_fp80 %a) nounwind readnone {
86115
; GISEL-X64-NEXT: subq $24, %rsp
87116
; GISEL-X64-NEXT: fldt {{[0-9]+}}(%rsp)
88117
; GISEL-X64-NEXT: fstpt (%rsp)
89-
; GISEL-X64-NEXT: callq ceill@PLT
118+
; GISEL-X64-NEXT: callq ceill
90119
; GISEL-X64-NEXT: addq $24, %rsp
91120
; GISEL-X64-NEXT: retq
121+
;
122+
; GISEL-X86-LABEL: ceil_f80:
123+
; GISEL-X86: # %bb.0:
124+
; GISEL-X86-NEXT: subl $12, %esp
125+
; GISEL-X86-NEXT: fldt {{[0-9]+}}(%esp)
126+
; GISEL-X86-NEXT: fstpt (%esp)
127+
; GISEL-X86-NEXT: calll ceill
128+
; GISEL-X86-NEXT: addl $12, %esp
129+
; GISEL-X86-NEXT: retl
92130
%c = call x86_fp80 @llvm.ceil.f80(x86_fp80 %a)
93131
ret x86_fp80 %c
94132
}
95-

‎llvm/test/CodeGen/X86/isel-floor.ll‎

Lines changed: 43 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
; RUN: llc < %s -mtriple=x86_64-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X64,FASTISEL-X64
44
; RUN: llc < %s -mtriple=i686-linux-gnu | FileCheck %s --check-prefixes=X86
55
; RUN: llc < %s -mtriple=i686-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X86
6-
; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=GISEL-X64
7-
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=X86
6+
; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=GISEL-X64
7+
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=GISEL-X86
88

99
define float @floor_f32(float %a) nounwind readnone {
1010
; DAG-X64-LABEL: floor_f32:
@@ -29,7 +29,19 @@ define float @floor_f32(float %a) nounwind readnone {
2929
;
3030
; GISEL-X64-LABEL: floor_f32:
3131
; GISEL-X64: # %bb.0:
32-
; GISEL-X64-NEXT: jmp floorf@PLT # TAILCALL
32+
; GISEL-X64-NEXT: pushq %rax
33+
; GISEL-X64-NEXT: callq floorf
34+
; GISEL-X64-NEXT: popq %rax
35+
; GISEL-X64-NEXT: retq
36+
;
37+
; GISEL-X86-LABEL: floor_f32:
38+
; GISEL-X86: # %bb.0:
39+
; GISEL-X86-NEXT: subl $12, %esp
40+
; GISEL-X86-NEXT: movl {{[0-9]+}}(%esp), %eax
41+
; GISEL-X86-NEXT: movl %eax, (%esp)
42+
; GISEL-X86-NEXT: calll floorf
43+
; GISEL-X86-NEXT: addl $12, %esp
44+
; GISEL-X86-NEXT: retl
3345
%c = call float @llvm.floor.f32(float %a)
3446
ret float %c
3547
}
@@ -57,7 +69,24 @@ define double @floor_f64(double %a) nounwind readnone {
5769
;
5870
; GISEL-X64-LABEL: floor_f64:
5971
; GISEL-X64: # %bb.0:
60-
; GISEL-X64-NEXT: jmp floor@PLT # TAILCALL
72+
; GISEL-X64-NEXT: pushq %rax
73+
; GISEL-X64-NEXT: callq floor
74+
; GISEL-X64-NEXT: popq %rax
75+
; GISEL-X64-NEXT: retq
76+
;
77+
; GISEL-X86-LABEL: floor_f64:
78+
; GISEL-X86: # %bb.0:
79+
; GISEL-X86-NEXT: subl $12, %esp
80+
; GISEL-X86-NEXT: leal {{[0-9]+}}(%esp), %eax
81+
; GISEL-X86-NEXT: movl {{[0-9]+}}(%esp), %ecx
82+
; GISEL-X86-NEXT: movl 4(%eax), %eax
83+
; GISEL-X86-NEXT: xorl %edx, %edx
84+
; GISEL-X86-NEXT: addl %esp, %edx
85+
; GISEL-X86-NEXT: movl %ecx, (%esp)
86+
; GISEL-X86-NEXT: movl %eax, 4(%edx)
87+
; GISEL-X86-NEXT: calll floor
88+
; GISEL-X86-NEXT: addl $12, %esp
89+
; GISEL-X86-NEXT: retl
6190
%c = call double @llvm.floor.f64(double %a)
6291
ret double %c
6392
}
@@ -86,10 +115,18 @@ define x86_fp80 @floor_f80(x86_fp80 %a) nounwind readnone {
86115
; GISEL-X64-NEXT: subq $24, %rsp
87116
; GISEL-X64-NEXT: fldt {{[0-9]+}}(%rsp)
88117
; GISEL-X64-NEXT: fstpt (%rsp)
89-
; GISEL-X64-NEXT: callq floorl@PLT
118+
; GISEL-X64-NEXT: callq floorl
90119
; GISEL-X64-NEXT: addq $24, %rsp
91120
; GISEL-X64-NEXT: retq
121+
;
122+
; GISEL-X86-LABEL: floor_f80:
123+
; GISEL-X86: # %bb.0:
124+
; GISEL-X86-NEXT: subl $12, %esp
125+
; GISEL-X86-NEXT: fldt {{[0-9]+}}(%esp)
126+
; GISEL-X86-NEXT: fstpt (%esp)
127+
; GISEL-X86-NEXT: calll floorl
128+
; GISEL-X86-NEXT: addl $12, %esp
129+
; GISEL-X86-NEXT: retl
92130
%c = call x86_fp80 @llvm.floor.f80(x86_fp80 %a)
93131
ret x86_fp80 %c
94132
}
95-

‎llvm/test/CodeGen/X86/isel-ftrunc.ll‎

Lines changed: 43 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
; RUN: llc < %s -mtriple=x86_64-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X64,FASTISEL-X64
44
; RUN: llc < %s -mtriple=i686-linux-gnu | FileCheck %s --check-prefixes=X86
55
; RUN: llc < %s -mtriple=i686-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X86
6-
; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=GISEL-X64
7-
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=X86
6+
; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=GISEL-X64
7+
; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=GISEL-X86
88

99
define float @trunc_f32(float %a) nounwind readnone {
1010
; DAG-X64-LABEL: trunc_f32:
@@ -29,7 +29,19 @@ define float @trunc_f32(float %a) nounwind readnone {
2929
;
3030
; GISEL-X64-LABEL: trunc_f32:
3131
; GISEL-X64: # %bb.0:
32-
; GISEL-X64-NEXT: jmp truncf@PLT # TAILCALL
32+
; GISEL-X64-NEXT: pushq %rax
33+
; GISEL-X64-NEXT: callq truncf
34+
; GISEL-X64-NEXT: popq %rax
35+
; GISEL-X64-NEXT: retq
36+
;
37+
; GISEL-X86-LABEL: trunc_f32:
38+
; GISEL-X86: # %bb.0:
39+
; GISEL-X86-NEXT: subl $12, %esp
40+
; GISEL-X86-NEXT: movl {{[0-9]+}}(%esp), %eax
41+
; GISEL-X86-NEXT: movl %eax, (%esp)
42+
; GISEL-X86-NEXT: calll truncf
43+
; GISEL-X86-NEXT: addl $12, %esp
44+
; GISEL-X86-NEXT: retl
3345
%c = call float @llvm.trunc.f32(float %a)
3446
ret float %c
3547
}
@@ -57,7 +69,24 @@ define double @trunc_f64(double %a) nounwind readnone {
5769
;
5870
; GISEL-X64-LABEL: trunc_f64:
5971
; GISEL-X64: # %bb.0:
60-
; GISEL-X64-NEXT: jmp trunc@PLT # TAILCALL
72+
; GISEL-X64-NEXT: pushq %rax
73+
; GISEL-X64-NEXT: callq trunc
74+
; GISEL-X64-NEXT: popq %rax
75+
; GISEL-X64-NEXT: retq
76+
;
77+
; GISEL-X86-LABEL: trunc_f64:
78+
; GISEL-X86: # %bb.0:
79+
; GISEL-X86-NEXT: subl $12, %esp
80+
; GISEL-X86-NEXT: leal {{[0-9]+}}(%esp), %eax
81+
; GISEL-X86-NEXT: movl {{[0-9]+}}(%esp), %ecx
82+
; GISEL-X86-NEXT: movl 4(%eax), %eax
83+
; GISEL-X86-NEXT: xorl %edx, %edx
84+
; GISEL-X86-NEXT: addl %esp, %edx
85+
; GISEL-X86-NEXT: movl %ecx, (%esp)
86+
; GISEL-X86-NEXT: movl %eax, 4(%edx)
87+
; GISEL-X86-NEXT: calll trunc
88+
; GISEL-X86-NEXT: addl $12, %esp
89+
; GISEL-X86-NEXT: retl
6190
%c = call double @llvm.trunc.f64(double %a)
6291
ret double %c
6392
}
@@ -86,10 +115,18 @@ define x86_fp80 @trunc_f80(x86_fp80 %a) nounwind readnone {
86115
; GISEL-X64-NEXT: subq $24, %rsp
87116
; GISEL-X64-NEXT: fldt {{[0-9]+}}(%rsp)
88117
; GISEL-X64-NEXT: fstpt (%rsp)
89-
; GISEL-X64-NEXT: callq truncl@PLT
118+
; GISEL-X64-NEXT: callq truncl
90119
; GISEL-X64-NEXT: addq $24, %rsp
91120
; GISEL-X64-NEXT: retq
121+
;
122+
; GISEL-X86-LABEL: trunc_f80:
123+
; GISEL-X86: # %bb.0:
124+
; GISEL-X86-NEXT: subl $12, %esp
125+
; GISEL-X86-NEXT: fldt {{[0-9]+}}(%esp)
126+
; GISEL-X86-NEXT: fstpt (%esp)
127+
; GISEL-X86-NEXT: calll truncl
128+
; GISEL-X86-NEXT: addl $12, %esp
129+
; GISEL-X86-NEXT: retl
92130
%c = call x86_fp80 @llvm.trunc.f80(x86_fp80 %a)
93131
ret x86_fp80 %c
94132
}
95-

0 commit comments

Comments
 (0)