[mlir][spirv]: Address Feedback

FranklandJack · FranklandJack · commit fd5c33dfb671 · 2025-07-29T07:38:53.000+01:00
Make variable type explicit in definition.

Signed-off-by: Jack Frankland &lt;jack.frankland@arm.com&gt;
diff --git a/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp b/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp
@@ -58,7 +58,7 @@ createGlobalVarForEntryPointArgument(OpBuilder &builder, spirv::FuncOp funcOp,
         spirv::PointerType::get(spirv::StructType::get(varType), *storageClass);
   }
   auto varPtrType = cast<spirv::PointerType>(varType);
-  auto pointeeType = varPtrType.getPointeeType();
+  Type pointeeType = varPtrType.getPointeeType();
 
   // Images are an opaque type and so we can just return a pointer to an image.
   // Note that currently only sampled images are supported in the SPIR-V

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ createGlobalVarForEntryPointArgument(OpBuilder &builder, spirv::FuncOp funcOp,`
`58`	`58`	`spirv::PointerType::get(spirv::StructType::get(varType), *storageClass);`
`59`	`59`	`}`
`60`	`60`	`auto varPtrType = cast<spirv::PointerType>(varType);`
`61`		`- auto pointeeType = varPtrType.getPointeeType();`
	`61`	`+ Type pointeeType = varPtrType.getPointeeType();`
`62`	`62`
`63`	`63`	`// Images are an opaque type and so we can just return a pointer to an image.`
`64`	`64`	`// Note that currently only sampled images are supported in the SPIR-V`