Skip to content

Commit fe9bf36

Browse files
committed
address PR comments
* Remove --no-gpuoffload options and tests
1 parent 9e4e9f3 commit fe9bf36

File tree

2 files changed

+0
-15
lines changed

2 files changed

+0
-15
lines changed

clang/lib/Driver/ToolChains/CommonArgs.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2622,11 +2622,6 @@ void tools::AddStaticDeviceLibs(Compilation *C, const Tool *T,
26222622
llvm::opt::ArgStringList &CC1Args,
26232623
StringRef Arch, StringRef Target,
26242624
bool isBitCodeSDL) {
2625-
2626-
// Check if offload libraries are disabled
2627-
if (!DriverArgs.hasFlag(options::OPT_offloadlib, options::OPT_no_offloadlib,
2628-
true))
2629-
return;
26302625

26312626
SmallVector<std::string, 8> LibraryPaths;
26322627
// Add search directories from LIBRARY_PATH env variable

clang/test/Driver/hipspv-link-static-library.hip

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,3 @@
2626

2727
// SDL-ARCHIVE: "{{.*}}clang-offload-bundler" "-unbundle" "-type=a" "-input={{.*}}libSDL.a" "-targets=hip-spirv64-unknown-unknown-unknown-generic" "-output=[[SDL_A:.*\.a]]" "-allow-missing-bundles"
2828
// SDL-ARCHIVE: "{{.*}}llvm-link" "{{.*}}.bc" "[[SDL_A]]" "-o"
29-
30-
// Test that no SDL linking occurs when --no-offloadlib is used
31-
// RUN: %clang -### --target=x86_64-linux-gnu --offload=spirv64 \
32-
// RUN: --hip-path=%S/Inputs/hipspv -nohipwrapperinc --no-offloadlib %s \
33-
// RUN: -L%t -lSDL \
34-
// RUN: 2>&1 | FileCheck -check-prefix=NO-SDL %s
35-
36-
// NO-SDL-NOT: "{{.*}}clang-offload-bundler" "-unbundle" "-type=a" "-input={{.*}}libSDL.a"
37-
38-
__global__ void kernel() {}

0 commit comments

Comments
 (0)