Skip to content

Commit ff687e5

Browse files
committed
Review feedback - DerefSizeExtractDataHelper doxygen comment and formatting
1 parent 8f6d74a commit ff687e5

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

lldb/source/Expression/DWARFExpression.cpp

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -861,14 +861,13 @@ ResolveLoadAddress(ExecutionContext *exe_ctx, lldb::ModuleSP &module_sp,
861861
return load_addr;
862862
}
863863

864-
/// Helper function to move common code used to load sized data from a uint8_t
865-
/// buffer.
864+
/// @brief Helper function to load sized data from a uint8_t buffer.
866865
///
867-
/// \param addr_bytes uint8_t buffer containg raw data
868-
/// \param size_addr_bytes how large is the underlying raw data
869-
/// \param byte_order what is the byter order of the underlyig data
870-
/// \param size How much of the underlying data we want to use
871-
/// \return The underlying data converted into a Scalar
866+
/// @param addr_bytes The buffer containing raw data.
867+
/// @param size_addr_bytes How large is the underlying raw data.
868+
/// @param byte_order What is the byte order of the underlying data.
869+
/// @param size How much of the underlying data we want to use.
870+
/// @return The underlying data converted into a Scalar.
872871
static Scalar DerefSizeExtractDataHelper(uint8_t *addr_bytes,
873872
size_t size_addr_bytes,
874873
ByteOrder byte_order, size_t size) {
@@ -877,8 +876,7 @@ static Scalar DerefSizeExtractDataHelper(uint8_t *addr_bytes,
877876
lldb::offset_t addr_data_offset = 0;
878877
if (size <= 8)
879878
return addr_data.GetMaxU64(&addr_data_offset, size);
880-
else
881-
return addr_data.GetAddress(&addr_data_offset);
879+
return addr_data.GetAddress(&addr_data_offset);
882880
}
883881

884882
static llvm::Error Evaluate_DW_OP_deref_size(DWARFExpression::Stack &stack,

0 commit comments

Comments
 (0)