Add MissingFeature for zero size member, fix var naming

Author: andykaylor

clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h

@@ -95,8 +95,8 @@ class CIRBaseBuilderTy : public mlir::OpBuilder {
       return getZeroAttr(arrTy);
     if (auto ptrTy = mlir::dyn_cast<cir::PointerType>(ty))
       return getConstNullPtrAttr(ptrTy);
-    if (auto RecordTy = mlir::dyn_cast<cir::RecordType>(ty))
-      return getZeroAttr(RecordTy);
+    if (auto recordTy = mlir::dyn_cast<cir::RecordType>(ty))
+      return getZeroAttr(recordTy);
     if (mlir::isa<cir::BoolType>(ty)) {
       return getCIRBoolAttr(false);
     }

clang/include/clang/CIR/MissingFeatures.h

@@ -110,6 +110,7 @@ struct MissingFeatures {
   static bool packedRecords() { return false; }
   static bool recordPadding() { return false; }
   static bool recordZeroInit() { return false; }
+  static bool zeroSizeRecordMembers() { return false; }
 
   // Misc
   static bool cxxABI() { return false; }

clang/lib/CIR/CodeGen/CIRGenRecordLayoutBuilder.cpp

@@ -180,6 +180,7 @@ void CIRRecordLowering::accumulateFields() {
       ++field;
     } else {
       // TODO(cir): do we want to do anything special about zero size members?
+      assert(!cir::MissingFeatures::zeroSizeRecordMembers());
       ++field;
     }
   }