LIBC_NAMESPACE contains illegal characters in -rc build

[vient]

https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0-rc1/cmake/Modules/LLVMVersion.cmake
+
https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0-rc1/libc/CMakeLists.txt#L47
results in #define LIBC_NAMESPACE __llvm_libc_19_1_0_-rc1 which is illegal

---

Side question: why rc suffixes contain hyphen while git suffix does not? https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0-rc1/llvm/utils/release/bump-version.py#L30-L34

[vient]

@tru

[llvmbot]

@llvm/issue-subscribers-libc

Author: vient (vient)

https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0-rc1/cmake/Modules/LLVMVersion.cmake + https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0-rc1/libc/CMakeLists.txt#L47 results in `#define LIBC_NAMESPACE __llvm_libc_19_1_0_-rc1` which is illegal _____ Side question: why `rc` suffixes contain hyphen while `git` suffix does not? https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0-rc1/llvm/utils/release/bump-version.py#L30-L34

[pmor13]

Same here. Trying to build llvmorg-19.1.0-rc3 with Clang 14.0.0.

[tru]

Side question: why rc suffixes contain hyphen while git suffix does not?

I think this is a legacy thing mostly. I wouldn't be against fixing that - but not for 19. But the next release will be the final one that drops the rc postfix completely, so I am not sure we need to rush a fix for this, but it can wait to LLVM 20.

[Thyre]

Same issue occurs with LLVM 20.1.0-r1. libc once again fails to build.

[Thyre]

Solved by 51759ff (and follow up in #126359)