-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Description
Currently for zstd support we search for a shared or static version of the zstd library. This works great in many cases, but in some cases that zstd might have compatibility issues.
For one when producing macOS binaries the zstd that you're likely to use is one installed via homebrew. Homebrew doesn't set a minimum macOS version for the things it builds, so by default the built zstd ends up targeting the current macOS version. This conflicts with us trying to produce binaries that support older macOS versions and could potentially cause runtime crashes.
This would also potentially allow folks to build with zstd even without having it installed.
I believe doing this would also fix this type of issue:
- LLVM build system error on Windows (zstd) #58558
- Build fails in Ubuntu 18.04 system with zstd development package installed #82114
- CMake failure with zstd, release 15.0.7 & 15.0.6 on OpenBSD #60350
I imagine this could be another option in the current zstd configuration, although it's possible the current configuration could be replaced by this instead if that was preferred.