[SandboxIR] Add more functions to sandboxir:Instruction class. #110050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getter functions simply turn around and call the LLVM counterparts. This is fine until we don't add new sandbox IR opcodes. At that point, we may have to explicitly check if the behavior is different.
vporpo
changed the title
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Sterling-Augustine
approved these changes
Sep 25, 2024
Contributor
Sterling-Augustine
left a comment
Sterling-Augustine
left a comment
There was a problem hiding this comment.
Pretty straight-forward pass through functions.
vporpo
reviewed
Sep 25, 2024
| //===--------------------------------------------------------------------===// | ||
|
|
||
| /// Return true if the instruction has any metadata attached to it. | ||
| bool hasMetadata() const { return cast<llvm::Instruction>(Val)->hasMetadata(); } |
Contributor
There was a problem hiding this comment.
Not sure about whether we should give access to metadata at this point, because these are LLVM IR structures and we can't really track their state.
Member
Author
There was a problem hiding this comment.
Removed getMetadata and getAllMetadata functions.
Add them back after MDNode is available in sandboxir. For now, exposing them could give access to functions that modify the metadata.
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/builds/5788 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/5786 Here is the relevant piece of the build log for the reference |
Contributor
|
This should fix it: 13809b3 |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/8673 Here is the relevant piece of the build log for the reference |
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Sep 27, 2024
…110050) The getter functions simply turn around and call the LLVM counterparts. This is fine until we don't add new sandbox IR opcodes. At that point, we may have to explicitly check if the behavior is different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getter functions simply turn around and call the LLVM
counterparts. This is fine until we don't add new sandbox IR
opcodes. At that point, we may have to explicitly check if
the behavior is different.