direct pushes to `main` branch

[kasperk81]

In reviewing recent commits, I’ve noticed instances where direct pushes to the main branch may have been made under urgency. While I understand that urgency can sometimes lead to quick changes, I believe it’s essential to prioritize the stability and integrity of the main branch.

I propose that we consider implementing a policy that prevents direct pushes to main and encourages the use of pull requests instead. This would ensure:

• Thorough Review: All changes are reviewed and discussed, which can help catch potential issues early.
• Collaboration: It fosters a more collaborative environment where contributions can be debated and improved upon.
• Stability: Protecting the main branch helps maintain a stable codebase, reducing the risk of introducing errors that could affect all users.

I’d love to hear your thoughts on this!

[llvmbot]

@llvm/issue-subscribers-infrastructure

Author: None (kasperk81)

In reviewing recent commits, I’ve noticed instances where direct pushes to the main branch may have been made under urgency. While I understand that urgency can sometimes lead to quick changes, I believe it’s essential to prioritize the stability and integrity of the main branch.

I propose that we consider implementing a policy that prevents direct pushes to main and encourages the use of pull requests instead. This would ensure:

• Thorough Review: All changes are reviewed and discussed, which can help catch potential issues early.
• Collaboration: It fosters a more collaborative environment where contributions can be debated and improved upon.
• Stability: Protecting the main branch helps maintain a stable codebase, reducing the risk of introducing errors that could affect all users.

I’d love to hear your thoughts on this!

[asl]

@kasperk81 This would be better discussed as RFC on Discourse. I would encourage you to submit topic there.

[kasperk81]

i'll close this. thanks!

[tstellar]

Note this has been discussed in the past. See https://discourse.llvm.org/t/rfc-requiring-pull-requests-for-contributions/78609

[kasperk81]

@tstellar looks like that proposal took things a bit too far. this is simply to "protect" main branch via PR. other branches and ways of working are unaffected. merging directly to main is very risky. if someone is hacked, they can rewrite the entire git history etc. imo, urgency and credibility is not a good excuse to allow people to do basically whatever.

[tstellar]

@kasperk81 I don't disagree with you. I just wanted to make you aware of this previous discussion. Feel free to start a new one on discourse.

[joker-eph]

they can rewrite the entire git history etc.

This isn't true: while we can freely push, we can't force-push today.