Skip to content

Conversation

@ldionne
Copy link
Member

@ldionne ldionne commented Sep 26, 2024

The CI has been a complete mess for the past week, and the only thing preventing it from being back is the Clang tidy checks. Disable them (as a total hack) to get CI back.

(cherry picked from commit 78c6506)

The CI has been a complete mess for the past week, and the only thing
preventing it from being back is the Clang tidy checks. Disable them (as
a total hack) to get CI back.

(cherry picked from commit 78c6506)
@ldionne ldionne added this to the LLVM 19.X Release milestone Sep 26, 2024
@ldionne ldionne requested a review from a team as a code owner September 26, 2024 20:01
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 26, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 26, 2024

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

The CI has been a complete mess for the past week, and the only thing preventing it from being back is the Clang tidy checks. Disable them (as a total hack) to get CI back.

(cherry picked from commit 78c6506)


Full diff: https://github.com/llvm/llvm-project/pull/110162.diff

1 Files Affected:

  • (modified) libcxx/test/tools/clang_tidy_checks/CMakeLists.txt (+2)
diff --git a/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt b/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt
index f0289dc44c6625..125b2184a49ea6 100644
--- a/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt
+++ b/libcxx/test/tools/clang_tidy_checks/CMakeLists.txt
@@ -1,3 +1,5 @@
+# TODO: Re-enable the tests once the CI is back under control
+return()
 
 # The find_package changes these variables. This leaves the build in an odd
 # state. Calling cmake a second time tries to write site config information in

@ldionne
Copy link
Member Author

ldionne commented Sep 26, 2024

@tru This patch should make the libc++ CI pass again. Unfortunately, it looks like we're going to have to let the clang-tidy checks go for now.

Once this passes CI (🤞), we can merge this, and then I can rebase #110161, #109324, #109291, #109054 and #106077 which should all pass.

@ldionne
Copy link
Member Author

ldionne commented Sep 26, 2024

@tru At this point, the important CI has passed. Please consider merging this so I can rebase the other libc++ PRs on top of it, get the CI to run and clear the backlog for the 19 milestone PRs.

@ldionne ldionne changed the title [libc++] Disable the clang-tidy checks to get CI back (#109989) [release/19.x][libc++] Disable the clang-tidy checks to get CI back (#109989) Sep 27, 2024
@tru tru merged commit 8a25c60 into llvm:release/19.x Oct 1, 2024
56 of 57 checks passed
@github-actions
Copy link

github-actions bot commented Oct 1, 2024

@ldionne (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

@ldionne ldionne deleted the review/llvm-19-get-ci-back branch October 1, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants