[mlir] remove-dead-values zero exit code on failure

[mtopalovicTT]

In case remove-dead-values pass emits error like below:

/localdev/mtopalovic/src/tt-mlir/test/ttmlir/Dialect/TTNN/simple_broadcast.mlir:3:1: error: cannot optimize an IR with non-function symbol ops, non-call symbol user ops or branch ops

mlir opt pass doesn't return failure but success.

This was discovered when llvm-lit reported that a test which emitted error above succeeded, but when command llvm-lit run was run manually you could see error above. This is because llvm-lit checks for error code in order to determine if test failed or succeeded.

Are we missing signalPassFailure in removeDeadValuePass

llvm-project/mlir/lib/Transforms/RemoveDeadValues.cpp

Line 584 in 10054ba

op->emitError() << "cannot optimize an IR with non-function symbol ops, "

[CoTinker]

llvm-project/mlir/lib/Transforms/RemoveDeadValues.cpp

Lines 591 to 592 in 10054ba

	if (acceptableIR.wasInterrupted())
	return;

Maybe you can add signalPassFailure here.