[NFC] [MTE] Use aarch64-linux-android34 for globals test #112050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
fmayer
added
the
skip-precommit-approval
llvmbot
added
clang
fmayer
added
the
skip-precommit-approval
Member
|
@llvm/pr-subscribers-clang Author: Florian Mayer (fmayer) ChangesIt doesn't make a difference currently, but MTE globals are only Full diff: https://github.com/llvm/llvm-project/pull/112050.diff 1 Files Affected:
diff --git a/clang/test/CodeGen/memtag-globals.cpp b/clang/test/CodeGen/memtag-globals.cpp
index b4f5dc0d7dcf04..d1252cdcd67a15 100644
--- a/clang/test/CodeGen/memtag-globals.cpp
+++ b/clang/test/CodeGen/memtag-globals.cpp
@@ -1,12 +1,15 @@
-// RUN: %clang_cc1 -include %S/Inputs/sanitizer-extra-source.cpp \
+// RUN: %clang_cc1 -triple aarch64-linux-android34 \
+// RUN: -include %S/Inputs/sanitizer-extra-source.cpp \
// RUN: -fsanitize-ignorelist=%S/Inputs/sanitizer-ignorelist-global.txt \
// RUN: -fsanitize=memtag-globals -emit-llvm -o - %s | FileCheck %s
-// RUN: %clang_cc1 -include %S/Inputs/sanitizer-extra-source.cpp \
+// RUN: %clang_cc1 -triple aarch64-linux-android34 \
+// RUN: -include %S/Inputs/sanitizer-extra-source.cpp \
// RUN: -fsanitize-ignorelist=%S/Inputs/sanitizer-ignorelist-src.txt \
// RUN: -fsanitize=memtag-globals -emit-llvm -o - %s | \
// RUN: FileCheck %s --check-prefix=IGNORELIST
+
int global;
int __attribute__((no_sanitize("memtag"))) attributed_global;
int __attribute__((disable_sanitizer_instrumentation)) disable_instrumentation_global;
|
…ndroid34-for-globals-test
fmayer
deleted the
users/fmayer/spr/nfc-mte-use-aarch64-linux-android34-for-globals-test
branch
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/3469 Here is the relevant piece of the build log for the reference |
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
It doesn't make a difference currently, but MTE globals are only supported on Android, so that's the more natural target to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make a difference currently, but MTE globals are only
supported on Android, so that's the more natural target to use.