Skip to content

Conversation

@fsfod
Copy link
Contributor

@fsfod fsfod commented Oct 17, 2024

Add include needed for DWARFContext to DwarfTransformer.h
Add include needed for windows types like HRESULT to DIAUtils.h

Add include needed for DWARFContext to DwarfTransformer.h
Add include needed for windows types like HRESULT to  DIAUtils.h
@llvmbot
Copy link
Member

llvmbot commented Oct 17, 2024

@llvm/pr-subscribers-debuginfo

Author: Thomas Fransham (fsfod)

Changes

Add include needed for DWARFContext to DwarfTransformer.h
Add include needed for windows types like HRESULT to DIAUtils.h


Full diff: https://github.com/llvm/llvm-project/pull/112766.diff

2 Files Affected:

  • (modified) llvm/include/llvm/DebugInfo/GSYM/DwarfTransformer.h (+1)
  • (modified) llvm/include/llvm/DebugInfo/PDB/DIA/DIAUtils.h (+1)
diff --git a/llvm/include/llvm/DebugInfo/GSYM/DwarfTransformer.h b/llvm/include/llvm/DebugInfo/GSYM/DwarfTransformer.h
index 3abf3bacabdd85..f5e821f7f1e651 100644
--- a/llvm/include/llvm/DebugInfo/GSYM/DwarfTransformer.h
+++ b/llvm/include/llvm/DebugInfo/GSYM/DwarfTransformer.h
@@ -11,6 +11,7 @@
 
 #include "llvm/ADT/StringRef.h"
 #include "llvm/DebugInfo/GSYM/ExtractRanges.h"
+#include "llvm/DebugInfo/DWARF/DWARFContext.h"
 #include "llvm/Support/Error.h"
 
 namespace llvm {
diff --git a/llvm/include/llvm/DebugInfo/PDB/DIA/DIAUtils.h b/llvm/include/llvm/DebugInfo/PDB/DIA/DIAUtils.h
index 5e01d8f10a6e70..015f26130ccf69 100644
--- a/llvm/include/llvm/DebugInfo/PDB/DIA/DIAUtils.h
+++ b/llvm/include/llvm/DebugInfo/PDB/DIA/DIAUtils.h
@@ -10,6 +10,7 @@
 #define LLVM_DEBUGINFO_PDB_DIA_DIAUTILS_H
 
 #include "llvm/ADT/ArrayRef.h"
+#include "llvm/DebugInfo/PDB/DIA/DIASupport.h"
 #include "llvm/Support/ConvertUTF.h"
 
 template <typename Obj>

Copy link
Collaborator

@dwblaikie dwblaikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@vgvassilev vgvassilev merged commit 5ee9c2c into llvm:main Oct 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants